Skip to content

Fix TypedDict with keys inherited from a base defined in a different module - #936

Merged
mauvilsa merged 2 commits into
mainfrom
fix-module-type-checking
Jul 28, 2026
Merged

Fix TypedDict with keys inherited from a base defined in a different module#936
mauvilsa merged 2 commits into
mainfrom
fix-module-type-checking

Conversation

@mauvilsa

Copy link
Copy Markdown
Owner

Before submitting

  • Did you read the contributing guideline?
  • If you used a coding agent, did you fully understand and validate all generated code and ensure it follows the contributing guidelines?
  • Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • If this is a bug fix, did you verify that the tests fail without the code fix?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added bug Something isn't working enhancement New feature or request labels Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (20ddc00) to head (245dba9).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #936   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         7798      7837   +39     
=========================================
+ Hits          7798      7837   +39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@mauvilsa
mauvilsa force-pushed the fix-module-type-checking branch from 344c6e0 to 245dba9 Compare July 28, 2026 17:56
@sonarqubecloud

Copy link
Copy Markdown

@mauvilsa
mauvilsa merged commit cf4b9f8 into main Jul 28, 2026
32 checks passed
@mauvilsa
mauvilsa deleted the fix-module-type-checking branch July 28, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant