Lev/feat/stale alert on subway status#3302
Open
lvachon1 wants to merge 25 commits into
Open
Conversation
…into lev/feat/stale_alert_on_subway_status
…ght as well follow through
…into lev/feat/stale_alert_on_subway_status # Conflicts: # test/alerts/alerts_test.exs
…into lev/feat/stale_alert_on_subway_status
…ime to determine the current starting time. Removed my redundant implementation.
…into lev/feat/stale_alert_on_subway_status
…e the result is always correct as time changes and the cached alert doesn't.
…into lev/feat/stale_alert_on_subway_status
thecristen
reviewed
Jul 9, 2026
thecristen
left a comment
thecristen
left a comment
Collaborator
There was a problem hiding this comment.
I'm curious if, philosophically, this new piece of logic is better off in Dotcom.SystemStatus.status_alert?/2 -- that function is currently used to filter alerts before passing them into the function this PR modified.
Contributor
Author
I tried that out and it should work, but looks like it'll also affect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🐬 Stale Symphony alert in subway current status
Implementation
Added a filter to remove
stale?alerts from the subway status indicator on the homepage.This builds upon the work already done in #3281
Screenshots
Dev-blue showing stale alert on green line
Local only showing the fresh blue line alert
How to test
This is hard. We cannot create alerts with start times in the past, so you have to find one somewhere in the wild. Tappan street seems to be the best test case at the moment.