Add general accessibility note to Trip Planner#3318
Conversation
…-type, arrow, and CSS classes. Used it for the new a11y notification on the trip planner
…. This should let us override them easier.
…sses won't cut it
There was no particular reason, I suppose I just didn't see much substance to those components and didn't think they were a good place to start. Mostly I just looked at the callout/cta components and picked the one that looked closest to the design in the ticket to use as a base for a generic version. In my mind I guess it was easier to take a component with everything on it, and add switches to toggle stuff. Either way I'm only making the 'too many similar components' problem worse here, and it would be wise to consolidate some of these components either by replacing them wholesale or having each one call cta with params and leaving the consumers alone. |
…is file are for the WC and will be removed
|
I tried to clean things up a bit here, callout and mbta_go_cta now call cta under the hood. The rest of the callouts seem to be WC specific and not long for this world, so I didn't think it was worth it to refactor those as well. |
thecristen
left a comment
thecristen
left a comment
There was a problem hiding this comment.
Cool! Just requesting changes for one thing: the emergent fake link behavior is awkward. While it's probably not technically inaccessible, IMO this'd be more semantically pleasing without it.
…rip_planner/a11y_notice
smartling-github-connector
Bot
added
the
Not Ready for Translation
thecristen
left a comment
thecristen
left a comment
There was a problem hiding this comment.
...sorry for missing this one in my prior reviews (!)
lvachon1
removed
the
Not Ready for Translation
…lanner/a11y_notice (#3331) * Translations delivered for PR#3318 on es-LA locale * Translations delivered for PR#3318 on ht-HT locale * Translations delivered for PR#3318 on zh-TW locale * Translations delivered for PR#3318 on pt-BR locale * Translations delivered for PR#3318 on fr-FR locale * Translations delivered for PR#3318 on vi-VN locale * Translations delivered for PR#3318 on zh-CN locale --------- Co-authored-by: smartling-github-connector[bot] <165276057+smartling-github-connector[bot]@users.noreply.github.com>
…nner/a11y_notice (#3334) * Translations updated for PR#3318 on es-LA locale * Translations updated for PR#3318 on ht-HT locale * Translations updated for PR#3318 on zh-TW locale * Translations updated for PR#3318 on pt-BR locale * Translations updated for PR#3318 on fr-FR locale * Translations updated for PR#3318 on zh-CN locale * Translations updated for PR#3318 on vi-VN locale --------- Co-authored-by: smartling-github-connector[bot] <165276057+smartling-github-connector[bot]@users.noreply.github.com>
thecristen
left a comment
thecristen
left a comment
There was a problem hiding this comment.
Hm, that's a new one... you'll have to fix this to get it to merge.
…m/mbta/dotcom into lev/feat/trip_planner/a11y_notice
2 participants
Scope
Asana Ticket: [By 7/13] 🗺️ Add general accessibility note to Trip Planner
Implementation
Created generic CTA/callout component with attrs for
link,icon,icon-type,arrow, and CSSclasses. Used it for the new a11y notification on the trip plannerScreenshots
How to test
http://localhost:4001/trip-planner
Check the a11y checkbox on and off and confirm the notice appears and disappears accordingly