fix(fares): Allow grouped fare cards to ingest Summarys#3329
Open
jlucytan wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🐞 500 error when visiting the latest (preview) version of the ferry fares page
Implementation
Changes a few group_fare_card calls to handle the case that the fare returned from
fare_from_tokenis a Summary instead of a Fare.Additionally trims whitespace from tokens so
ferry_winthrop(note the space) doesn't result in aninvalidfareScreenshots
Before
before fixing grouped fare card:
after fixing grouped fare card, before trimming single tokens:
After
How to test
Verify that this ferry fare preview page loads and properly displays the grouped fare and the Winthrop fare.