test: undo synctest adoption#253
Merged
Merged
Conversation
This backs out the synctest changes from #240. While saving a few seconds on the test suite is nice, I think it's probably more important to have a more straightforward test suite that actually exercises a real HTTP server over a real TCP connection given the nature of this specific project. (Plus, the `netpipetestserver` mechanism is a bit too hacky for my taste.) Also, those synctests prevent a different set of changes I'd like to make, which would allow pointing the test suite at a "live" deployment to ensure that whatever cloud infra go-httpbin is running on actually supports some of the edge case behavior (e.g. in the past Google Cloud Run's load balancers did not allow incremental writes).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 94.72% 94.87% +0.15%
==========================================
Files 9 9
Lines 1991 1991
==========================================
+ Hits 1886 1889 +3
+ Misses 62 59 -3
Partials 43 43 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backs out the synctest changes from #240. While saving a few seconds on the test suite is nice, I think it's probably more important to have a more straightforward test suite that actually exercises a real HTTP server over a real TCP connection given the nature of this specific project. (Plus, the
netpipetestservermechanism needed to support those tests is a bit too hacky for my taste.)In addition, those synctests prevent a different set of changes I'd like to make, which would allow pointing the test suite at a "live" deployment to ensure that whatever cloud infra go-httpbin is running on actually supports some of the edge case behavior (e.g. in the past Google Cloud Run's load balancers did not allow incremental writes).
Best way to look at the diff here is with whitespace-only changes ignored:
https://github.com/mccutchen/go-httpbin/pull/253/changes?w=1
I apologize to the maintainers of any long-lived forks who are trying to keep up with these changes. Between #238, #240, and this pull request, that's a LOT of churn to the test suite that will be awful to merge/rebase.