release: v0.0.4 — glob exclusion, xlings layout, auto sandbox PATH#21
Merged
Sunrisepeak merged 2 commits intomainfrom May 9, 2026
Merged
release: v0.0.4 — glob exclusion, xlings layout, auto sandbox PATH#21Sunrisepeak merged 2 commits intomainfrom
Sunrisepeak merged 2 commits intomainfrom
Conversation
Three quality-of-life improvements: 1. **Glob exclusion (`!` prefix)** in `[modules].sources` / Form B sources. Patterns starting with `!` expand to a set of paths that are subtracted from the include set. This lets upstreams like ftxui declare `["src/**/*.cpp", "!src/**/*_test.cpp"]` instead of listing 73 files individually. Implemented in `scan_one_into` (scanner.cppm) and `stage_with_rewrite` (cli.cppm). 2. **xlings at `registry/bin/`** instead of `bin/`. The bundled xlings binary now sits at `<MCPP_HOME>/registry/bin/xlings`, which IS `<XLINGS_HOME>/bin/xlings`. xlings 0.4.x's shim-creation guard (`if fs::exists(homeDir/"bin"/"xlings")`) is trivially satisfied, making `ensure_sandbox_xlings_binary` a no-op. Eliminates the hardlink dance and the "two binaries in bin/" confusion. 3. **`mcpp test` inherits sandbox PATH**. Before invoking each test binary, mcpp now prepends `<XLINGS_HOME>/subos/default/bin` to `$PATH`. Tools bootstrapped during sandbox init — patchelf, ninja, and any xim shims — are visible to test binaries that shell out to them, fixing the "patchelf: command not found" failures that libxpkg's elfpatch tests hit in CI.
Tests 10 and 27 checked for xlings at $MCPP_HOME/bin/xlings; the 0.0.4 layout moved it to $MCPP_HOME/registry/bin/xlings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three QoL improvements for 0.0.4:
sources = ["src/**/*.cpp", "!src/**/*_test.cpp"]subtracts excluded paths from the include set. Unblocks upstreams like ftxui whose test files sit alongside library sources.registry/bin/— the bundled xlings now sits at<MCPP_HOME>/registry/bin/xlings(=<XLINGS_HOME>/bin/xlings), eliminating the hardlink dance and putting it where xlings's shim guard expects it.mcpp testsandbox PATH — test binaries inherit<XLINGS_HOME>/subos/default/binin PATH so patchelf/ninja/etc. are findable.Test plan
v0.0.4→ release workflow