Fix #44618: Temporal.ZonedDateTime.add() offset ambiguity example and description#44693
Open
hanu-14 wants to merge 1 commit into
Open
Fix #44618: Temporal.ZonedDateTime.add() offset ambiguity example and description#44693hanu-14 wants to merge 1 commit into
hanu-14 wants to merge 1 commit into
Conversation
…add() The description claimed add()/subtract() use offset: "prefer" for offset-ambiguous results, but the spec's AddZonedDateTime uses disambiguation: "compatible" (same as the date-time validity logic). Also fix the second example where subtracting one day from 2024-11-04T01:00:00-05:00 should give 2024-11-03T01:00:00-04:00. Fixes mdn#44618
github-actions
Bot
added
Content:JS
Josh-Cena
requested review from
Josh-Cena
and removed request for
sideshowbarker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mdn/content#44618
The Description section of
Temporal.ZonedDateTime.prototype.add()claimed that offset-ambiguous results useoffset: "prefer", but the spec's AddZonedDateTime algorithm usesdisambiguation: "compatible"— the same mechanism as the date-time validity bullet directly above.Also fixes the second example: subtracting one day from
2024-11-04T01:00:00-05:00[America/New_York]yields2024-11-03T01:00:00-04:00[America/New_York](offset -04:00, not -05:00 as previously stated).