fix(border-image-generator): put border-image-source last in CSS output - #217
Open
AzazelSensei wants to merge 1 commit into
Open
fix(border-image-generator): put border-image-source last in CSS output#217AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Reorder the CSS Code properties so short values appear first and the lengthy border-image-source data URL is last, matching issue mdn#93.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Reorder the CSS Code property blocks in the border-image generator so short properties come first and
border-image-source(often a long data URL) is last.Motivation:
When copying CSS, developers often skip the lengthy
border-image-sourceand can miss later properties such asborder-style, which Chrome needs for the border image to show. Putting the source last keeps the important short properties easy to copy.Additional details:
border-style→border-image-slice→border-image-width→border-image-outset→border-image-repeat→border-image-sourcescript.jswiring stays intactRelated issues and pull requests:
Fixes #93