Fix batch of reported issues (#18, #19, #23, #25, #26, #27, #28)

[engalar]

Summary

Fixes for issues reported at engalar/mxcli:

• bug: DESCRIBE MICROFLOW omits WHILE loop body activities engalar/mxcli#18: DESCRIBE MICROFLOW now emits END WHILE and traverses WHILE loop body correctly
• bug: Long attribute/parameter/constant type silently downgraded to Integer engalar/mxcli#19: Long type written as DataTypes$LongType instead of incorrect IntegerType
• bug: DataGrid2 column names replaced by sequential identifiers in DESCRIBE engalar/mxcli#23: DataGrid2 column names derived from attribute name or caption
• bug: DESCRIBE CONSTANT omits COMMENT field engalar/mxcli#25: DESCRIBE CONSTANT now emits COMMENT field with proper escaping
• bug: Date attribute type stored and described as DateTime (no Date-only type) engalar/mxcli#26: Date added as distinct type from DateTime throughout parser, AST, writer, and executor
• DESCRIBE emits incorrect $ prefix on enum literal in RETURN expression, causing CE0109 on roundtrip engalar/mxcli#27: DESCRIBE omits incorrect $ prefix on qualified enum literals in RETURN
• MDL parser fails to parse inline if...then...else expression in SET statement engalar/mxcli#28: Inline if-then-else expression support in MDL grammar and executor
• XPath tokens written unquoted to prevent CE0161
• ComboBox association binding sets AttributeRef correctly
• isQualifiedEnumLiteral tightened to require 2+ dots (Module.Enum.Value pattern)

Test plan

• Regression tests added in bugfix_regression_test.go covering all fixed issues
• Existing tests pass (go test ./...)
• Manual validation with Mendix Studio Pro for Date type and XPath fixes

Note: The large diff in mdl/grammar/parser/mdl_parser.go (~13k lines) is auto-generated by ANTLR4 from the grammar change for inline if-then-else expressions.

🤖 Generated with Claude Code

[ako]

Code Review

+9605 / -2783 across 35 files, 10 commits. Fixes a batch of reported issues. ~13k lines of the diff is auto-generated ANTLR parser.

---

Overlap with Main

Fix	Status on Main	Notes
#18 WHILE loop END WHILE keyword	Partially on main	CREATE/format already handle WHILE. DESCRIBE emits END LOOP; instead of END WHILE;. Body traversal already works via emitLoopBody. Only the keyword fix is needed.
#19 Long as DataTypes$LongType	Already on main — duplicate	Will likely cause merge conflicts
#23 DataGrid2 column names	Not on main — needed
#25 DESCRIBE CONSTANT COMMENT	Not on main — needed
#26 Date vs DateTime distinction	Partially on main	AST has TypeDate, but no microflows.DateType struct
#27 Enum literal $ prefix in RETURN	Not on main — needed
#28 Inline if-then-else expressions	Not on main — needed
XPath tokens unquoted	Not on main — needed
ComboBox association AttributeRef	Partially on main	EntityRef set but not AttributeRef
isQualifiedEnumLiteral 2+ dots	Not on main — needed

Fix #19 (LongType) is fully duplicate and should be dropped to avoid conflicts.

---

Bugs

1. HIGH: DateTime roundtrip regression — absent LocalizeDate defaults to Date
sdk/mpr/parser_domainmodel.go — The new parser logic:

localize, _ := raw["LocalizeDate"].(bool)
if localize { return DateTimeAttributeType }
return DateAttributeType  // Date

If LocalizeDate is absent from BSON (all MPR files written by older code, and possibly older Mendix versions), the type assertion yields false, and all existing DateTime attributes are misclassified as Date. Fix: default to DateTime when absent:

localize, ok := raw["LocalizeDate"].(bool)
if !ok || localize { return DateTimeAttributeType }
return DateAttributeType

2. MEDIUM: Same absent-LocalizeDate issue in cmd_diff_local.go
mdl/executor/cmd_diff_local.go — Both LocalizeDate checks default to "Date" when the field is absent (ok=false). Should default to "DateTime".

3. MEDIUM: DateType can never be produced by the microflow parser
sdk/mpr/parser_microflow.go — Both Date and DateTime map to DataTypes$DateTimeType in BSON. The parser always returns DateTimeType and has no way to distinguish. The new DateType struct is created but can never be produced by the parser, so DESCRIBE MICROFLOW will always show DateTime even for Date variables.

4. MEDIUM: Business events writer doesn't set LocalizeDate for Date
sdk/mpr/writer_businessevents.go — Maps both "DateTime" and "Date" to DomainModels$DateTimeAttributeType but creates a simple {$Type, $ID} object without setting LocalizeDate=false for Date. These will roundtrip as DateTime.

5. LOW: isQualifiedEnumLiteral is too broad
cmd_microflows_format_action.go — strings.Count(s, ".") >= 2 matches any string with 2+ dots (e.g., some.java.ClassName). Probably safe in the RETURN value context but could be tightened.

---

What looks good

• END WHILE keyword fix (#18) is clean and targeted
• DataGrid2 column name derivation (#23) is well-implemented with sensible fallback
• DESCRIBE CONSTANT COMMENT (#25) is straightforward
• Enum literal $ prefix fix (#27) addresses a real CE0109 roundtrip issue
• Inline if-then-else (#28) grammar addition is well-tested
• XPath token unquoting prevents real CE0161 errors
• Good regression test coverage (26 tests in bugfix_regression_test.go)

Overall: The DateTime roundtrip regression (bug #1) is the main blocker — it would break every existing DateTime attribute when reading an MPR. Fix #19 is duplicate and should be dropped. The remaining fixes are solid and needed.

🤖 Generated with Claude Code