Build fix for R1 Neo and Minewsemi repeater - #3142
Open
oltaco wants to merge 3 commits into
Open
Conversation
added missing declarations for user_btn and NullDisplayDriver
fixes minewsemi repeater failing build due to user_btn missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R1 Neo and Minewsemi repeater failed to build on v1.17 due to missing user_btn declaration.
This PR adds the missing declarations and does a bit of a tidy up in platformio.ini.
All R1 Neo and Minewsemi firmware types confirmed as building but I don't have these devices so I can't test unfortunately.