Add vrf service - #174
Draft
iljarotar wants to merge 1 commit into
Draft
Conversation
majst01
reviewed
Aug 12, 2026
| // SwitchServiceGetRequest is the request payload for getting a switch. | ||
| message SwitchServiceGetRequest { | ||
| // Id of the switch to get | ||
| // Id of the switch to get. |
Contributor
There was a problem hiding this comment.
maybe better to have a dedicated punctuation fix pr.
Contributor
Author
There was a problem hiding this comment.
Yes, I pushed this by mistake.
| import "metalstack/api/v2/predefined_rules.proto"; | ||
| import "metalstack/api/v2/vrf.proto"; | ||
|
|
||
| // VRFService provides endpoints for managing VRFs connecting to machines outside of metal-stack. |
Contributor
There was a problem hiding this comment.
Guess this needs to be discussed, i thought a network must be created, which creates a vrf and then we can add a administrative endpoint to expose the vrf of this network on additional switchports which do not have a machine connected.
Contributor
Author
There was a problem hiding this comment.
This makes a lot more sense. What do you think the endpoint should look like?
service NetworkService {
rpc AddSwitchPorts(NetworkServiceAddSwitchPortRequest) returns (NetworkServiceAddSwitchPortResponse) {
option (metalstack.api.v2.admin_roles) = ADMIN_ROLE_EDITOR;
option (metalstack.api.v2.auditing) = AUDITING_INCLUDED;
}
}
message NetworkServiceAddSwitchPortRequest {
// VrfPorts maps switch IDs to the respective switch's ports that should be bound by this VRF.
map<string, VRFPorts> vrf_ports = 1;
}
message VRFPorts {
repeated metalstack.api.v2.SwitchNic nics = 1;
}Something like this?
Contributor
There was a problem hiding this comment.
yes, but the request must contain the network for which these ports should be bound
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description