Conversation
… image - Enhance test framework with proto yaml/json validators using WantObject field - Clean up commented-out dead code in common_test.go and ip_test.go - Enable IP list test (Test_IPCmd_MultiResult) - Add IP describe yaml/json coverage via WantObject - Add project describe + list tests with all 6 output formats - Add tenant describe test with yaml, json, template formats - Add token describe test with yaml, json, template formats - Add image list test with table, wide, template, markdown formats Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
majst01
reviewed
Mar 19, 2026
cmd/api/v2/ip.go
Outdated
|
|
||
| resp, err := c.c.Client.Apiv2().IP().Create(ctx, rq) | ||
| if err != nil { | ||
| if connectErr, ok := errors.AsType[*connect.Error](err); ok && connectErr.Code() == connect.CodeAlreadyExists { |
Contributor
There was a problem hiding this comment.
should always be a connect.Error
Contributor
There was a problem hiding this comment.
Or we introduce errorutils here as well
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Project's Convert() doesn't make API calls (unlike IP which calls Get inside IpResponseToUpdate), so from-file operations go directly to the target operation without a preceding Get call. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
This should be quite a good start to work with now. |
majst01
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Let's introduce some E2E tests again.
Used AI-Tools ✨