fix: derive persistability from source presence, not object subtype

[dmealing]

Intent

Issue #248 (npm-only PATCH, packages migrate-ts + codegen-ts): persistability derives from a declared/inherited source.* child, NEVER from object subtype. (1) migrate-ts expected-schema Pass 1: replaced a hardcoded subType==="value" compare with a "skip unless a writable source is declared/inherited" gate, so a sourceless object no longer gets a phantom CREATE TABLE or a fabricated FK-target name. (2) codegen-ts queries/routes/routes-hono/api-model plus the src/reference/* scaffold copies: gate DB-artifact emission on a new hasAnyRdbSource helper (mirrors the already-correct Drizzle table tier's hasWritableRdbSource), fixing broken generated files for sourceless objects INCLUDING a pre-existing object.value broken-routes fail-open. Plus byte-identical bare-source fixture adaptations across consuming packages (cli/integration-tests) and a CHANGELOG entry. This ALIGNS both tiers to the loader's already-published contract (validate-source-roles: zero sources means not persisted) -- it is a BUGFIX, not a behavior-contract change; meta gen / meta migrate output is byte-identical for well-formed models (the norm, where every table-owning object declares or inherits a source). A whole-branch senior review already returned Ready-to-merge with no Critical/Important findings. Closes #248.

DELIBERATELY OUT OF SCOPE -- design-approved deferrals (design spec section 9), do NOT flag these as missing: a cross-port LOADER error for an enforced identity.reference to a non-persisted target (9a); a cross-port codegen audit of the same fail-open in the Java/Python/Kotlin/C# generators (9b -- those ports emit no DDL, lower stakes); client hook parity in the react/tanstack client packages (9c); a migrate/verify --entities scope filter (9d); routes-file-hono TPH gating (9e, a pre-existing gap, no regression here).

KNOWN-DEFERRED cosmetic MINORS (the final review triaged these defer-acceptable -- do NOT block merge on them): a double-wrapped expect(()=>{...}).not.toThrow() around an assertion in expected-schema-persistability.test.ts test 2; stale mirror-comment line references at api-model.ts around line 347; a queries-file.test.ts test name that reads as subtype-based though the filter is now source-based; the api-model isQueryable sourceless-exclusion not pinned by a dedicated test; soft ("roughly 150") blast-radius numbers in the CHANGELOG. KNOWN RESIDUAL: the full packages/integration-tests suite (16 files beyond the 2 view-lifecycle files that were run green) was not run locally -- CI's slow lane covers it, and the reviewer scanned all 16 and confirmed none relies on the phantom-table behavior.

What Changed

• migrate-ts expected-schema Pass 1 now gates table emission on a declared/inherited writable source instead of a hardcoded subType === "value" check, so sourceless objects no longer emit phantom CREATE TABLE statements or fabricated FK-target names.
• codegen-ts gates queries, routes, routes-hono, and api-model emission (plus the src/reference/* scaffold copies) on a new hasAnyRdbSource helper, so sourceless objects no longer emit broken DB artifacts — closing a pre-existing object.value broken-routes fail-open.
• Output is byte-identical for well-formed models (every table-owning object already declares or inherits a source); both tiers now align to the loader's published "zero sources = not persisted" contract. Consuming-package fixtures adapted accordingly, plus a CHANGELOG entry.

Closes #248.

Risk Assessment

✅ Low: A focused, well-tested npm-only bugfix that aligns migrate-ts and codegen-ts to an already-enforced loader invariant (zero sources ⇒ not persisted): byte-identical for well-formed models, all load-bearing assumptions independently verified (value-source ban is loader-enforced on the resolving view; bare-source fixture naming falls through to the same pluralized-snake-case fallback), and every behavioral change is pinned by new tests — the only residual items are the author's explicitly-deferred cosmetic minors and cross-port follow-ups.

Testing

Exercised the fix at three levels, all green: the two new pinning unit tests, the directly-affected regression unit suites (migrate-ts expected-schema family + codegen-ts queries/byte-identical, gating the byte-identical-for-well-formed-models claim), and the real-DB view-lifecycle integration tests (Testcontainers Postgres + SQLite). Then demonstrated the end-user surface by driving the actual meta CLI on a sourceless-object fixture with an Order→sourceless-Ghost reference: meta gen emits no DB-bound artifacts for sourceless/value objects, and meta migrate emits a single CREATE TABLE with no phantom table and no fabricated FK target. No failures or setup issues.

Evidence: meta gen transcript — sourceless-object fixture

Fixture: Order (source.rdb orders, identity.reference→Ghost), Ghost (entity, NO source), Money (object.value, NO source). $ meta gen summary: 6 written gen-out/Order.ts, gen-out/Ghost.ts, gen-out/Money.ts, gen-out/Order.queries.ts, gen-out/Order.routes.ts, gen-out/Order.routes.hono.ts DB-bound artifacts for sourceless/value objects (MUST be absent): absent(correct): Ghost.queries.ts, Ghost.routes.ts, Ghost.routes.hono.ts, Money.queries.ts, Money.routes.ts, Money.routes.hono.ts Ghost.ts is a clean shape-only interface (no Drizzle table/allowlist import); Order.routes.ts imports the real orders table from ./Order.js. Before #248, routes-file.ts emitted Ghost.routes.ts importing a never-generated ghosts table/allowlist (TS2305/TS2724 breakage).

gen[6]{file,status}:
  gen-out/Order.ts,new
  gen-out/Ghost.ts,new
  gen-out/Money.ts,new
  gen-out/Order.queries.ts,new
  gen-out/Order.routes.ts,new
  gen-out/Order.routes.hono.ts,new
summary: 6 written
help[2]: typecheck the generated code with `npx tsc`,create your database tables with `meta migrate --from-db --db <url> --dialect <sqlite|postgres> --slug init --apply`
--- gen-out listing ---
Ghost.ts
Money.ts
Order.queries.ts
Order.routes.hono.ts
Order.routes.ts
Order.ts
--- absence check ---
absent(correct): Ghost.queries.ts
absent(correct): Ghost.routes.ts
absent(correct): Ghost.routes.hono.ts
absent(correct): Money.queries.ts
absent(correct): Money.routes.ts
absent(correct): Money.routes.hono.ts

Evidence: meta migrate transcript — sourceless-object fixture

$ meta migrate --from-db --db file:dev.sqlite --dialect sqlite --slug init --dry-run -- UP -- CREATE TABLE "orders" ( "id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "reference" TEXT, "ghost_id" INTEGER ); changes: 1 create-table Result: exactly ONE CREATE TABLE (orders, the sourced entity). No phantom CREATE TABLE "ghosts"/"moneys" for the sourceless/value objects, and ghost_id is a plain INTEGER column with NO fabricated REFERENCES ghosts(...) FK — before #248 the sourceless Ghost got a phantom table + fabricated FK-target name.

# meta migrate (dry-run, fresh sqlite) — Order references sourceless Ghost

Fixture: Order has identity.reference(@references Ghost). Ghost has NO source.rdb.
Before #248 this fabricated a phantom CREATE TABLE ghosts + a REFERENCES ghosts(...) FK.

## $ meta migrate --from-db --db file:dev.sqlite --dialect sqlite --slug init --dry-run
-- UP --
CREATE TABLE "orders" (
  "id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL,
  "reference" TEXT,
  "ghost_id" INTEGER
);

-- DOWN --
DROP TABLE "orders";
changes[1]{kind,count}:
  create-table,1
written: []
summary: 1 create-table; preview only (nothing written)
help[1]: re-run without --dry-run to write the migration

## Assertions
 - CREATE TABLE "orders" present (sourced entity persists): 1

Pipeline

Updates from git push no-mistakes

✅ **intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

✅ **Review** - passed

✅ No issues found.

✅ **Test** - passed

✅ No issues found.

• bun test packages/migrate-ts/test/expected-schema-persistability.test.ts (4 pass — the migrate Pass-1 gate pin: sourceless entity → no table, no fabricated FK target, custom subtype → no table, inherited writable source via extends → persists)
• bun test packages/codegen-ts/test/sourceless-objects.test.ts (4 pass — engine + reference generators gate queries/routes/hono on hasAnyRdbSource; read-only projection still queryable; Order.* byte-identical whether or not sourceless objects co-load)
• bun test packages/migrate-ts/test/expected-schema.test.ts expected-schema-tph.test.ts expected-schema-fk-constraint-name.test.ts expected-schema-schema-aware.test.ts expected-schema-field-object-storage.test.ts unit/expected-schema*.test.ts (56 pass — regression cover for table/view partition)
• bun test packages/codegen-ts/test/generators/queries-file.test.ts reference-byte-identical.test.ts sourceless-objects.test.ts (14 pass — byte-identical-for-well-formed-models gate)
• bun test packages/integration-tests/test/view-lifecycle-pg.test.ts view-lifecycle-sqlite.test.ts (18 pass — real Postgres+SQLite via Testcontainers; the migrate table-vs-view partition applies round-trip)
• meta gen on a fixture (Order sourced + identity.reference→Ghost; Ghost sourceless entity; Money object.value) — 6 files written, all Ghost.*/Money.* queries/routes/hono absent
• meta migrate --from-db --db file:dev.sqlite --dialect sqlite --slug init --dry-run on the same fixture — exactly 1 CREATE TABLE orders, no phantom ghosts/moneys table, ghost_id plain column with no fabricated REFERENCES ghosts(...) FK

✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.