Re-enable Windows Rust tests#235
Draft
Luthaf wants to merge 7 commits into
Draft
Conversation
Luthaf
force-pushed
the
enable-windows-build
branch
from
8c4b08e to
658b4ac
Compare
…d shadowing MSVC's link.exe
Git bash re-adds its own /usr/bin to PATH on every invocation, so removing it from $GITHUB_ENV had no effect. Directly removing Git's link.exe (a Unix hardlink utility) lets MSVC's link.exe take precedence. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When the Visual Studio generator is used for the outer cmake build, cargo is invoked from within MSBuild. If cargo then runs cmake internally (e.g. metatensor-sys building metatensor from source), that inner cmake inherits CMAKE_GENERATOR=Visual Studio and tries to launch a nested MSBuild, which fails to detect C/C++ compilers. Overriding CMAKE_GENERATOR=NMake Makefiles for the cargo subprocess avoids the nesting: cl.exe and nmake.exe are both in PATH after the ilammy/msvc-dev-cmd setup step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor (creator of pull-request) checklist
Reviewer checklist