Skip to content

Add USB CDC transport example for ESP-IDF (Humble)#307

Open
Mohamed-Sejid wants to merge 1 commit into
micro-ROS:humblefrom
Mohamed-Sejid:humble
Open

Add USB CDC transport example for ESP-IDF (Humble)#307
Mohamed-Sejid wants to merge 1 commit into
micro-ROS:humblefrom
Mohamed-Sejid:humble

Conversation

@Mohamed-Sejid

Copy link
Copy Markdown

adds a micro-ROS example for the ESP-IDF environment on the humble branch on how to use the USB CDC transport for communication in the same way that the examples are available on the kilted branch

@mergify

mergify Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

@Mohamed-Sejid, all pull requests must be targeted towards the rolling development branch.
Once merged into rolling, it is possible to backport to humble, but it must be in rolling
to have these changes reflected in new distributions.

Can be ignored for this PR as it's essentially a backport.

@Narukara

Copy link
Copy Markdown
Contributor

🤔 Do we actually want to add this? It was intentionally not added to humble before. #263 (comment)

Currently, CI builds this example on humble. We can make it skip that.

@EugenioCollado @Amronos

@Amronos

Amronos commented May 27, 2026

Copy link
Copy Markdown
Member

I think the intention behind not backporting it before was to avoid a maintenance burden.
That should no longer be a problem, as 3 of us are maintaining the software right now. Additionally, Humble is going to stay for another year.
Perhaps we should just reopen #263 instead.

@Narukara

Copy link
Copy Markdown
Contributor

I think the intention behind not backporting it before was to avoid a maintenance burden. That should no longer be a problem, as 3 of us are maintaining the software right now. Additionally, Humble is going to stay for another year. Perhaps we should just reopen #263 instead.

OK. I will check the differences between this PR and the original backport.

@Narukara

Copy link
Copy Markdown
Contributor

According to Mohamed-Sejid, this PR should be based on kilted. I have confirmed that the original backport is completely consistent with the current int32_publisher_custom_transport_usbcdc on kilted. Compared to kilted/the original backport, this PR does introduce some meaningful changes, so I recommend continuing the work based on this PR. However, this PR also appears to introduce a number of unrelated changes, particularly in main.c.

@Mohamed-Sejid, would you mind re-editing this to keep the code as consistent as possible with kilted, retaining only the necessary changes? Alternatively, I can do it myself.

@mergify

mergify Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@Narukara

Copy link
Copy Markdown
Contributor

Since I haven't received a response for a while, I'll continue working on this branch. I need to add CI tests for this example. But since this branch is several commits behind and the ci.yml has undergone significant changes in the meantime, I have to rebase this branch.

@Narukara Narukara force-pushed the humble branch 2 times, most recently from 4628823 to 9647f3b Compare June 23, 2026 08:02
@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@Narukara

Copy link
Copy Markdown
Contributor

The example currently added is essentially the same as the one in the original backport or on the kilted branch. Only the following changes have been made:

  1. Modifications in main.c for humble compatibility.
  2. Added useful information to the README — maybe we should also add to other branches?
  3. Added CI.

@Amronos

Amronos commented Jun 23, 2026

Copy link
Copy Markdown
Member

Could you move the README information to a separate PR targeted to rolling? That would make it easier to backport those changes to all distros.

Co-authored-by: Narukara <narukara@foxmail.com>
@Narukara

Copy link
Copy Markdown
Contributor

Could you move the README information to a separate PR targeted to rolling? That would make it easier to backport those changes to all distros.

Moved to #360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants