Skip to content

Fix rolling builds#323

Open
Amronos wants to merge 1 commit intomicro-ROS:rollingfrom
Amronos:fix-rolling
Open

Fix rolling builds#323
Amronos wants to merge 1 commit intomicro-ROS:rollingfrom
Amronos:fix-rolling

Conversation

@Amronos
Copy link
Copy Markdown
Member

@Amronos Amronos commented Feb 25, 2026

Some packages needed to be pinned to older versions, and COLCON_IGNORE had to be added to some new ones.
Look at the PR diff for more info.


This is part 2 of 4 in a stack made with GitButler:

Changes specific to this PR: d2c43d8

@Amronos Amronos force-pushed the fix-rolling branch 2 times, most recently from 77f944b to be6b0e5 Compare February 25, 2026 12:24
@Amronos Amronos force-pushed the fix-rolling branch 2 times, most recently from b85c158 to d2c43d8 Compare April 15, 2026 11:40
@Amronos Amronos mentioned this pull request Apr 15, 2026
@EugenioCollado
Copy link
Copy Markdown
Contributor

I have just merged the first PR. Rerunning the CI now

@Amronos
Copy link
Copy Markdown
Member Author

Amronos commented Apr 28, 2026

This PR is good to merge from my side. The current failures are related to embeddedRTPS, which I would say is out of the scope of this PR. After all current PRs are merged, I will make a PR to temporarily disable its builds in CI until we fix it/it gets updated to rolling.

@Amronos
Copy link
Copy Markdown
Member Author

Amronos commented Apr 29, 2026

@Narukara @EugenioCollado could you review/merge this PR

Comment thread libmicroros.mk Outdated
@Amronos Amronos requested a review from Narukara April 29, 2026 12:06
Copy link
Copy Markdown
Contributor

@Narukara Narukara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good now. Could you provide a bit more detail about the fix made in this PR?

@Narukara Narukara mentioned this pull request Apr 30, 2026
@Amronos Amronos force-pushed the fix-rolling branch 2 times, most recently from 18fe3f2 to 1a34225 Compare May 5, 2026 09:13
@Amronos Amronos requested a review from Narukara May 5, 2026 09:14
@Amronos
Copy link
Copy Markdown
Member Author

Amronos commented May 5, 2026

Sorry for the delay, @Narukara. I have explained the changes in detail in the comments added to libmicroros.mk.

@Narukara
Copy link
Copy Markdown
Contributor

Narukara commented May 6, 2026

LGTM

Sorry for the delay,

No problem at all — it's been the holidays lately.

@EugenioCollado
Copy link
Copy Markdown
Contributor

EugenioCollado commented May 6, 2026

Hi @Amronos and @Narukara , based on the comment ros2/rclc needs to be pinned to an older version until ros2/rcl#1269 is added in micro-ROS/rcl as ros2/rclc#435 depends on it. I have created in micro-ROS/rcl the branch test/rolling which is a rebase on top of the upstream rolling. I suggest making a temporal commit for testing using that branch and see if that fixes that issue (I would rebase then the actual rolling branch). If not, I can cherry pick just the commit from ros2/rcl#1269 and then test again. If neither fixes the issue let's go with the current reset approach.

@Amronos
Copy link
Copy Markdown
Member Author

Amronos commented May 7, 2026

Thanks a lot @EugenioCollado! Looks like that worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants