Upgrade the Bootstrap version, update microformats crate, align with other repositories - #1
Open
Zegnat wants to merge 7 commits into
Open
Upgrade the Bootstrap version, update microformats crate, align with other repositories#1Zegnat wants to merge 7 commits into
Zegnat wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on microformats/microformats-parser-website-python#22.
I am trying to do a refresh of the pages. Partly triggered by the fact that we are using a deprecated CDN to serve an alpha version of Bootstrap today. This takes the front-end design that was done over on Python.
As I was working on it, I noticed we are out of date on the crate(s). Ended up doing an update of those as well.
To get parity between the pages, this also introduces the bookmarklet call-to-action. For this we have to expose a GET endpoint to trigger parsing. I am not a Rust developer, but thankfully I did not need to write much code and
poemmade it fairly easy. I would still love an extra pair of eyes on my edits to the main.rs though, @jalcine maybe has a minute?Note on merging: happy to get any and all feedback, but want to forewarn that I might merge this in myself within the next few days just to keep the momentum going 🚀