Fido: accept lowercase hybrid QR URI scheme#3636
Open
Jadeiin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept hybrid QR URI schemes case-insensitively in
QrCodeData.parse().HybridAuthenticateActivitycurrently accepts theFIDO:/prefix withignoreCase = true, butQrCodeData.parse()extracts the payload using the case-sensitive expression:Android delivered a valid hybrid registration URI using a lowercase scheme:
The activity accepted the URI, but the parser failed to find the uppercase
FIDO:/prefix, decoded an empty payload, and returnednull.Fix
Validate the prefix case-insensitively and remove it by length:
This keeps the encoded payload unchanged while accepting valid casing variations.