Improve case_input.nc output handling#2
Open
Sandro-Meier-Empa wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR enhances save_case_input() to better support xarray metadata and safer file writes by adding an overwrite guard and propagating .attrs into the generated NetCDF output.
Changes:
- Replace
os.pathpath handling withpathlib.Path, and add anoverwriteflag to control clobbering existing output files. - Introduce
add_attrs()to persist xarray-style attributes onto NetCDF variables/groups. - Update variable writing to extract
.valuesforxarray.DataArrayinputs and attach attributes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR improves
save_case_input()by allowing overwrites and preserving metadata from xarray inputs.Changes
xarray.DataArray.attrswhen writing variables to NetCDF.overwrite=Falseargument tosave_case_input().FileExistsErrorwhen the target input file already exists unlessoverwrite=True.pathlib.Pathfor output file path handling.