Skip to content

Fix undefined 'notebook' parameter in azpapermill_iterator template - #195

Open
Manya Sharma (ManyaS-Git) wants to merge 1 commit into
microsoft:masterfrom
ManyaS-Git:fix/azpapermill-iterator-param
Open

Fix undefined 'notebook' parameter in azpapermill_iterator template#195
Manya Sharma (ManyaS-Git) wants to merge 1 commit into
microsoft:masterfrom
ManyaS-Git:fix/azpapermill-iterator-param

Conversation

@ManyaS-Git

Copy link
Copy Markdown

Summary

.ci/steps/azpapermill_iterator.yml references ${{parameters.notebook}} (singular) in its inline script, but the template declares notebooks: (plural) in its own parameters: block, and the only caller (.ci/steps/ADOTrainDeployAMLJob.yml) passes notebooks:.

Referencing an undeclared template parameter makes Azure Pipelines template expansion fail, so this template cannot compile. The fix aligns the echo statement with the rest of the script, which already loops over ${{parameters.notebooks}}.

Verification

  • The sibling template .ci/steps/azpapermill.yml declares notebook: (singular) and correctly uses ${{parameters.notebook}} everywhere — the plural/singular split here is purely a copy/paste artifact.
  • Bug confirmed present on upstream microsoft/AI master.
  • File still parses as valid YAML.

@ArshVermaGit Arsh Verma (ArshVermaGit) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The parameter mismatch is correctly fixed, and the verification confirms the template remains valid. Approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants