Skip to content

fix: only deliver artifact with same type as artifact to upload as release artifact#2321

Open
OleWunschmann wants to merge 4 commits into
microsoft:mainfrom
OleWunschmann:fix-deliver-to-of-release-workflow
Open

fix: only deliver artifact with same type as artifact to upload as release artifact#2321
OleWunschmann wants to merge 4 commits into
microsoft:mainfrom
OleWunschmann:fix-deliver-to-of-release-workflow

Conversation

@OleWunschmann

@OleWunschmann OleWunschmann commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

❔What, Why & How

The UploadArtifacts job in CreateRelease.yaml runs as a matrix over all artifact types (Apps, TestApps, Dependencies, …). Previously, each matrix iteration called the Deliver to NuGet and Deliver to Storage steps with hardcoded atypes lists ('Apps,TestApps' and 'Apps,TestApps,Dependencies'), regardless of which artifact type the current iteration was actually processing. This caused the Deliver action to be invoked with the hardcoded artifact types in each iteration.

This change introduces a Determine delivery targets step that:

  • Evaluates whether nuGetContext/storageContext secrets are configured
  • Checks whether the current matrix.atype is eligible for each delivery target
  • Writes deliverToNuGet and deliverToStorage outputs (true/false)

The Deliver to NuGet and Deliver to Storage steps now gate on those outputs and pass only matrix.atype as atypes, so each matrix iteration delivers exactly its own artifact type to the appropriate target.

Related to issue: #2320

✅ Checklist

  • Add tests (E2E, unit tests)
  • Update RELEASENOTES.md
  • Update documentation (e.g. for new settings or scenarios)
  • Add telemetry

@OleWunschmann
OleWunschmann requested a review from a team as a code owner July 17, 2026 19:21
Copilot AI review requested due to automatic review settings July 17, 2026 19:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes duplicate NuGet/storage delivery across release artifact matrix jobs.

Changes:

  • Determines delivery eligibility per artifact type and configured secret.
  • Delivers only the current matrix artifact type.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
Templates/Per Tenant Extension/.github/workflows/CreateRelease.yaml Updates PTE release delivery logic.
Templates/AppSource App/.github/workflows/CreateRelease.yaml Mirrors the fix for AppSource releases.

Comment thread Templates/Per Tenant Extension/.github/workflows/CreateRelease.yaml
Comment thread Templates/AppSource App/.github/workflows/CreateRelease.yaml
Comment thread Templates/Per Tenant Extension/.github/workflows/CreateRelease.yaml
OleWunschmann and others added 3 commits July 17, 2026 21:28
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants