fix: only deliver artifact with same type as artifact to upload as release artifact#2321
Open
OleWunschmann wants to merge 4 commits into
Open
fix: only deliver artifact with same type as artifact to upload as release artifact#2321OleWunschmann wants to merge 4 commits into
OleWunschmann wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes duplicate NuGet/storage delivery across release artifact matrix jobs.
Changes:
- Determines delivery eligibility per artifact type and configured secret.
- Delivers only the current matrix artifact type.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Templates/Per Tenant Extension/.github/workflows/CreateRelease.yaml |
Updates PTE release delivery logic. |
Templates/AppSource App/.github/workflows/CreateRelease.yaml |
Mirrors the fix for AppSource releases. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
The
UploadArtifactsjob inCreateRelease.yamlruns as a matrix over all artifact types (Apps,TestApps,Dependencies, …). Previously, each matrix iteration called theDeliver to NuGetandDeliver to Storagesteps with hardcodedatypeslists ('Apps,TestApps'and'Apps,TestApps,Dependencies'), regardless of which artifact type the current iteration was actually processing. This caused theDeliveraction to be invoked with the hardcoded artifact types in each iteration.This change introduces a
Determine delivery targetsstep that:nuGetContext/storageContextsecrets are configuredmatrix.atypeis eligible for each delivery targetdeliverToNuGetanddeliverToStorageoutputs (true/false)The
Deliver to NuGetandDeliver to Storagesteps now gate on those outputs and pass onlymatrix.atypeasatypes, so each matrix iteration delivers exactly its own artifact type to the appropriate target.Related to issue: #2320
✅ Checklist