Potential fix for code scanning alert no. 5402: Semicolon insertion#2727
Merged
Potential fix for code scanning alert no. 5402: Semicolon insertion#2727
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
Author
|
@copilot update this PR by updating the branch |
Co-authored-by: MSNev <54870357+MSNev@users.noreply.github.com>
Contributor
Branch has been updated by merging the latest changes from |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR addresses the code scanning alert about possible semicolon insertion by making the arrow-function assignment in DiagnosticLogger.ts terminate explicitly with a semicolon, without changing behavior.
Changes:
- Add an explicit semicolon after the
_self.throwInternal = (...) => { ... }assignment. - Leave surrounding logic, imports, and method structure unchanged.
JacksonWeber
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/microsoft/ApplicationInsights-JS/security/code-scanning/5402
Add an explicit semicolon after the
_self.throwInternal = (...) => { ... }assignment inshared/AppInsightsCore/src/diagnostics/DiagnosticLogger.ts(the block ending at current line 170).Best fix without changing functionality:
}of that assignment statement to};.No new methods/imports/definitions are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.