Skip to content

[Extensibility Request] issue 30346: make InsertPostValueEntryToGL public in Item Jnl.-Post Line#9467

Open
AleksandricMarko wants to merge 1 commit into
mainfrom
ai-ext-fix/ext_issue-30346
Open

[Extensibility Request] issue 30346: make InsertPostValueEntryToGL public in Item Jnl.-Post Line#9467
AleksandricMarko wants to merge 1 commit into
mainfrom
ai-ext-fix/ext_issue-30346

Conversation

@AleksandricMarko

@AleksandricMarko AleksandricMarko commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

An extension author wants to post additional variances and reuse the standard General Ledger posting logic that already lives in codeunit 22 Item Jnl.-Post Line. They already call the public PostInventoryToGL procedure, but InsertPostValueEntryToGL was declared local and therefore unreachable from extensions. This PR exposes that procedure so extensions can invoke the standard posting flow.

Source issue repository: microsoft/AlAppExtensions; issue number: 30346

Changes Made

  • InsertPostValueEntryToGL (codeunit 22 Item Jnl.-Post Line) - changed from a local procedure to a public procedure so extensions can call the standard value-entry-to-G/L posting logic. Applied in the W1 base layer and mirrored to the same-named counterparts in the APAC, CH, ES, IT, and RU layers.

Fixes AB#642120

….-Post Line

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@AleksandricMarko AleksandricMarko added request-for-external SCM GitHub request for SCM area labels Jul 15, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 15, 2026
@AleksandricMarko
AleksandricMarko marked this pull request as ready for review July 20, 2026 07:24
@AleksandricMarko
AleksandricMarko requested a review from a team July 20, 2026 07:24
Comment thread src/Layers/W1/BaseApp/Inventory/Posting/ItemJnlPostLine.Codeunit.al
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Reviewed a 6-file diff that widens the access modifier of InsertPostValueEntryToGL from local to public identically across six country-layer copies of codeunit 22 "Item Jnl.-Post Line". All sixteen composed sub-skills were invoked; only al-breaking-changes-review found applicable knowledge.

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain Findings Knowledge-backed Agent Inline Fallback
Breaking Changes 1 1 0 1 0

Totals: 1 knowledge-backed · 0 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

request-for-external SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant