Skip to content

Allow pull_request:linked-issue ownership source#9565

Merged
JesperSchulz merged 3 commits into
mainfrom
jesperschulz-allow-linked-issue-ownership-source
Jul 17, 2026
Merged

Allow pull_request:linked-issue ownership source#9565
JesperSchulz merged 3 commits into
mainfrom
jesperschulz-allow-linked-issue-ownership-source

Conversation

@JesperSchulz

@JesperSchulz JesperSchulz commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Symptom

The team-ownership classification workflow (.github/workflows/ownership-classification.yml) in microsoft/BCApps rejects correct classifications as malformed, failing with:

The ownership result from BCAppsTriage was malformed, so no labels were changed.

This broke a real PR: microsoft/BCApps #9561 (base releases/28.x, linked issue #5383) was correctly classified as team Integration with source: pull_request:linked-issue, but the workflow threw the malformed error and applied no labels.

Root cause

The Validate and apply ownership result step validates result.ownership.source against a hardcoded sources allowlist. A merged BCAppsTriage change (PR #40, linked-issue PR routing) added a new emitted source value pull_request:linked-issue — a PR whose team is adopted from its linked issue when the changed files are ambiguous. The BCApps allowlist was never updated, so any such result is rejected as malformed.

Fix

Add 'pull_request:linked-issue' to the sources allowlist, immediately after 'pull_request:incomplete-files'. This restores parity with the classifier's decision.js source set in BCAppsTriage — the only emitted source value missing from the allowlist. The allowlist now contains all 12 valid source values.

Single-line change; no other edits.

Fixes AB#642506

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a2b420d9-1366-4113-8d97-65e472d15bf3
@JesperSchulz
JesperSchulz requested review from a team July 17, 2026 07:58
@github-actions github-actions Bot added Build: Automation Workflows and other setup in .github folder Other GitHub request for other area than SCM, Finance or Integration Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction labels Jul 17, 2026
mazhelez
mazhelez previously approved these changes Jul 17, 2026
gggdttt
gggdttt previously approved these changes Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 3 · Outcome: no-knowledge

All 16 sub-skills ran and found no applicable AL knowledge: the PR's only changed file is a non-AL GitHub Actions workflow (.github/workflows/ownership-classification.yml), so no leaf's Worklist matched any content.

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

No findings were posted for this iteration.

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

Add issue:title-keyword and issue:body-keyword to the sources allowlist ahead of BCAppsTriage PR #42 (matrix-driven keyword tier).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a2b420d9-1366-4113-8d97-65e472d15bf3
@JesperSchulz
JesperSchulz dismissed stale reviews from gggdttt and mazhelez via 8285d7a July 17, 2026 08:08
@JesperSchulz JesperSchulz changed the title Allow pull_request:linked-issue ownership source Allow linked-issue and issue keyword ownership sources Jul 17, 2026
BCAppsTriage PR #42 was updated to map its keyword tier onto existing sources and no longer emits issue:title-keyword / issue:body-keyword, so those allowlist entries are unnecessary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a2b420d9-1366-4113-8d97-65e472d15bf3
@JesperSchulz JesperSchulz changed the title Allow linked-issue and issue keyword ownership sources Allow pull_request:linked-issue ownership source Jul 17, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 17, 2026
@JesperSchulz
JesperSchulz added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit 81a30cc Jul 17, 2026
21 checks passed
@JesperSchulz
JesperSchulz deleted the jesperschulz-allow-linked-issue-ownership-source branch July 17, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build: Automation Workflows and other setup in .github folder Other GitHub request for other area than SCM, Finance or Integration Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants