Allow pull_request:linked-issue ownership source#9565
Merged
JesperSchulz merged 3 commits intoJul 17, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2b420d9-1366-4113-8d97-65e472d15bf3
mazhelez
previously approved these changes
Jul 17, 2026
gggdttt
previously approved these changes
Jul 17, 2026
Contributor
Copilot PR ReviewIteration 3 · Outcome: no-knowledge
Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf No findings were posted for this iteration. Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives. |
Add issue:title-keyword and issue:body-keyword to the sources allowlist ahead of BCAppsTriage PR #42 (matrix-driven keyword tier). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2b420d9-1366-4113-8d97-65e472d15bf3
BCAppsTriage PR #42 was updated to map its keyword tier onto existing sources and no longer emits issue:title-keyword / issue:body-keyword, so those allowlist entries are unnecessary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2b420d9-1366-4113-8d97-65e472d15bf3
mazhelez
approved these changes
Jul 17, 2026
darjoo
approved these changes
Jul 17, 2026
JesperSchulz
deleted the
jesperschulz-allow-linked-issue-ownership-source
branch
July 17, 2026 10:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
The team-ownership classification workflow (
.github/workflows/ownership-classification.yml) in microsoft/BCApps rejects correct classifications as malformed, failing with:This broke a real PR: microsoft/BCApps #9561 (base
releases/28.x, linked issue #5383) was correctly classified as teamIntegrationwithsource: pull_request:linked-issue, but the workflow threw the malformed error and applied no labels.Root cause
The
Validate and apply ownership resultstep validatesresult.ownership.sourceagainst a hardcodedsourcesallowlist. A merged BCAppsTriage change (PR #40, linked-issue PR routing) added a new emitted source valuepull_request:linked-issue— a PR whose team is adopted from its linked issue when the changed files are ambiguous. The BCApps allowlist was never updated, so any such result is rejected as malformed.Fix
Add
'pull_request:linked-issue'to thesourcesallowlist, immediately after'pull_request:incomplete-files'. This restores parity with the classifier'sdecision.jssource set in BCAppsTriage — the only emitted source value missing from the allowlist. The allowlist now contains all 12 valid source values.Single-line change; no other edits.
Fixes AB#642506