Skip to content

[Master]-Rounding Differences in ARAP with Deferrals and Non-Deductible VAT#9570

Open
DeepsShukla wants to merge 1 commit into
mainfrom
bugs/Bug-640614-Rounding-Differences-in-ARAP-with-Deferrals
Open

[Master]-Rounding Differences in ARAP with Deferrals and Non-Deductible VAT#9570
DeepsShukla wants to merge 1 commit into
mainfrom
bugs/Bug-640614-Rounding-Differences-in-ARAP-with-Deferrals

Conversation

@DeepsShukla

@DeepsShukla DeepsShukla commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Workitem Bug 642527: [Main]-Rounding Differences in ARAP with Deferrals and Non-Deductible VAT
Fixes AB#64527

@DeepsShukla
DeepsShukla requested a review from a team July 17, 2026 09:17
@github-actions github-actions Bot added the Finance GitHub request for Finance area label Jul 17, 2026

[IntegrationEvent(false, false)]
local procedure OnBeforeInsertDeferralNonDeductibleVATGLEntries(var NonDeductibleVATPct: Decimal; DeferralPostingBuffer: Record "Deferral Posting Buffer"; VATPostingSetup: Record "VAT Posting Setup"; GenJournalLine: Record "Gen. Journal Line"; DeferralTemplate: Record "Deferral Template"; var VATAmountRounding: Decimal; var PositiveNDVATAmountRounding: Decimal; var NegativeNDVATAmountRounding: Decimal; var IsHandled: Boolean)
local procedure OnBeforeInsertDeferralNonDeductibleVATGLEntries(var NonDeductibleVATPct: Decimal; DeferralPostingBuffer: Record "Deferral Posting Buffer"; VATPostingSetup: Record "VAT Posting Setup"; GenJournalLine: Record "Gen. Journal Line"; DeferralTemplate: Record "Deferral Template"; var PositiveVATAmountRounding: Decimal; var NegativeVATAmountRounding: Decimal; var PositiveNDVATAmountRounding: Decimal; var NegativeNDVATAmountRounding: Decimal; var IsHandled: Boolean)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟠\ High\ Severity\ —\ Events} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

The local IntegrationEvent OnBeforeInsertDeferralNonDeductibleVATGLEntries in codeunit 12 ("Gen.

Jnl.-Post Line", W1 layer) removed its existing var parameter VATAmountRounding and replaced it with two new parameters PositiveVATAmountRounding and NegativeVATAmountRounding. Even though the event publisher is local, subscribers can still bind to it by parameter name; removing/renaming an existing parameter breaks any existing subscriber that references VATAmountRounding by name, per AS0063/AS0077. New parameters may be added at any position on a local/internal event, but the existing parameter name, type, and var mode must be preserved.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain Findings Knowledge-backed Agent Inline Fallback
Events 1 1 0 1 0

Totals: 1 knowledge-backed · 0 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants