Skip to content

Enable RU tests#9576

Open
spetersenms wants to merge 1 commit into
mainfrom
spetersen/RUTests
Open

Enable RU tests#9576
spetersenms wants to merge 1 commit into
mainfrom
spetersen/RUTests

Conversation

@spetersenms

@spetersenms spetersenms commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Enables RU tests.

AB#642528

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

@spetersenms
spetersenms requested review from a team July 17, 2026 10:46
@github-actions github-actions Bot added Build: scripts & configs Build scripts and configuration files Finance GitHub request for Finance area labels Jul 17, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 17, 2026
@@ -0,0 +1,24 @@
codeunit 147210 "RU Report Download Handler"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟠\ High\ Severity\ —\ Events} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

RU Report Download Handler is a static event-subscriber codeunit, so it intercepts every File Management.OnBeforeDownloadHandler call in the session.

Because this copy-to-target workaround is needed only for specific RU report-test flows, leaving it always bound can suppress unrelated downloads and change other tests with no way to turn the behavior off. Make the subscriber manual or gate it behind explicit activation for the tests that need it.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain Findings Knowledge-backed Agent Inline Fallback
Agent 1 0 1 0 0
Events 1 1 0 1 0

Totals: 1 knowledge-backed · 1 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

@JesperSchulz JesperSchulz added Other GitHub request for other area than SCM, Finance or Integration Ownership: Manual Preserve the manually selected team ownership and removed Finance GitHub request for Finance area labels Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build: scripts & configs Build scripts and configuration files Other GitHub request for other area than SCM, Finance or Integration Ownership: Manual Preserve the manually selected team ownership

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants