Skip to content

636017 Move Inventory report action tooltips to report objects#9582

Open
V-CWurtzen wants to merge 2 commits into
mainfrom
features/636017-Inventory-move-page-action-tooltips-to-report
Open

636017 Move Inventory report action tooltips to report objects#9582
V-CWurtzen wants to merge 2 commits into
mainfrom
features/636017-Inventory-move-page-action-tooltips-to-report

Conversation

@V-CWurtzen

@V-CWurtzen V-CWurtzen commented Jul 17, 2026

Copy link
Copy Markdown

What & why

Moves the report action ToolTips for 11 Inventory reports off the page actions that run them and onto the report objects themselves. The tooltip is now defined once on the report and applies wherever the report is invoked — the page action inherits it via the 2025 release wave 1 feature "Running objects in actions defaults to UI descriptors on target object" — and the now-duplicate ToolTip is removed from the page actions.

Reports moved: Inventory - Customer Sales, Inventory - Sales Back Orders, Inventory - Top 10 List, Inventory - Transaction Detail, Inventory - Vendor Purchases, Inventory Availability, Inventory Order Details, Inventory Purchase Orders, Item Age Composition - Value, Item Expiration - Quantity, Item/Vendor Catalog.

This completes the Inventory area — the pre-migration ADO pass left these behind, including reports skipped by a since-fixed tooling bug (reports with obsolete dataset columns). classify now reports Inventory = 0 remaining.

Scope

  • W1 (src/Layers/W1/BaseApp): 18 files — 11 report-level ToolTip adds + 21 duplicate action ToolTip removals across 7 pages/role centers. Some referencing actions live in other namespaces (Finance / Purchases / Sales / shared RoleCenters); those are cleaned too, so the move is complete regardless of where the report is invoked.
  • Country: 45 forks across 18 country layers (1 report-fork add + 43 page removals + 1 NoOp presence-touch).

Metadata-only, tooltip-only diff; BOM/EOL preserved.

Fixes AB#636017

Completes the Inventory W1 move (the pre-GitHub ADO pass left these behind,
including reports skipped by the now-fixed scan-tooltips obsolete-column bug).
Moves 11 reports -- Inventory - Customer Sales, Inventory - Sales Back Orders,
Inventory - Top 10 List, Inventory - Transaction Detail, Inventory - Vendor
Purchases, Inventory Availability, Inventory Order Details, Inventory Purchase
Orders, Item Age Composition - Value, Item Expiration - Quantity, Item/Vendor
Catalog -- adding report-level ToolTips and removing the 21 duplicate action
ToolTips across 7 pages/role centers (Inventory, plus cross-namespace refs on
Finance / Purchases / Sales / shared RoleCenters).

classify now reports Inventory = 0 RealMiss / 0 Stub / 0 ResidualDup (remaining
9 are intentional obsolete skips). Tooltip-only; BOM/EOL preserved.
Country propagation for the Inventory W1 move across 18 country layers: the
NA Item/Vendor Catalog report fork gets the report-level ToolTip; 43 page/
role-center forks have the duplicate action ToolTips removed (89 removals);
1 NoOp presence-touch on NA PurchasingAgentRoleCenter (a cross-namespace fork
with no covered action). Fork set derived with Invoke-Miapp (authoritative);
changed set exactly matches (0 missing / 0 extra). Tooltip-only; BOM/EOL/
trailing-newline preserved.
@V-CWurtzen
V-CWurtzen requested a review from a team July 17, 2026 15:19
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

$\textbf{🟡\ Medium\ Severity\ —\ UI} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

This PR moves ToolTip text from page actions to the underlying Report objects and removes it from the calling actions, relying on the Business Central platform's RunObject-based Caption/ToolTip inheritance.

Per Microsoft's documented behaviour (RunObject property, 'with Business Central 2025 release wave 1'), that automatic inheritance applies only to 'actions on role centers' that specify RunObject. 'Item List' (src/Layers/*/BaseApp/Inventory/Item/ItemList.Page.al, PageType = List) and 'Req. Worksheet' (src/Layers/{NA,W1}/BaseApp/Inventory/Requisition/ReqWorksheet.Page.al, PageType = Worksheet) are not role centers, so their actions with RunObject = Report "Item/Vendor Catalog", "Inventory Availability", "Inventory - Transaction Detail", "Item Expiration - Quantity", "Inventory - Customer Sales", "Inventory - Top 10 List", "Item Age Composition - Value", "Inventory Order Details", and "Inventory Purchase Orders" will lose their hover tooltip entirely in the client, even though the Report objects now carry the text. Affected files: src/Layers/APAC/BaseApp/Inventory/Item/ItemList.Page.al, src/Layers/GB/BaseApp/Inventory/Item/ItemList.Page.al, src/Layers/IT/BaseApp/Inventory/Item/ItemList.Page.al, src/Layers/NA/BaseApp/Inventory/Item/ItemList.Page.al, src/Layers/RU/BaseApp/Inventory/Item/ItemList.Page.al, src/Layers/W1/BaseApp/Inventory/Item/ItemList.Page.al, src/Layers/NA/BaseApp/Inventory/Requisition/ReqWorksheet.Page.al, src/Layers/W1/BaseApp/Inventory/Requisition/ReqWorksheet.Page.al. Restore an explicit ToolTip on each of these actions (the Role Center actions in the same PR are unaffected because inheritance does apply there).

Agent judgement — not directly backed by a BCQuality knowledge article.

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain Findings Knowledge-backed Agent Inline Fallback
UI 1 0 1 0 1

Totals: 0 knowledge-backed · 1 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

@github-actions github-actions Bot added Other GitHub request for other area than SCM, Finance or Integration Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction labels Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Other GitHub request for other area than SCM, Finance or Integration Ownership: Needs Review Ownership is Other, low confidence, or needs manual correction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant