636017 Move Sales report action tooltips to report objects#9583
Open
V-CWurtzen wants to merge 2 commits into
Open
636017 Move Sales report action tooltips to report objects#9583V-CWurtzen wants to merge 2 commits into
V-CWurtzen wants to merge 2 commits into
Conversation
Completes the Sales W1 move (the pre-GitHub ADO pass left these behind, including reports skipped by the now-fixed scan-tooltips obsolete-column bug). Moves 5 reports -- Customer - Order Detail, Customer - Order Summary, Customer/Item Sales, Salesperson - Commission, Salesperson - Sales Statistics -- adding report-level ToolTips and removing the 23 duplicate action ToolTips (descriptive + stub variants) across 9 pages/role centers, including cross-namespace refs on CRM / Finance / shared RoleCenters. classify now reports Sales = 0 RealMiss / 0 Stub / 0 ResidualDup (remaining 42 are intentional obsolete skips). Tooltip-only; BOM/EOL preserved.
Country propagation for the Sales W1 move across 18 country layers: 3 report forks (APAC Customer/Item Sales, APAC Salesperson - Sales Statistics, RU Customer - Order Summary) get the report-level ToolTip; 52 page/role-center forks have the duplicate action ToolTips removed (152 removals); 1 NoOp presence-touch on NA AccReceivablesAdmRC (a cross-namespace fork with no covered action). Fork set derived with Invoke-Miapp (authoritative); changed set exactly matches (0 missing / 0 extra). Tooltip-only; BOM/EOL/ trailing-newline preserved.
github-actions
Bot
added
Other
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed
Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Moves the report action ToolTips for 5 Sales reports off the page actions that run them and onto the report objects themselves. The tooltip is now defined once on the report and applies wherever the report is invoked — the page action inherits it via the 2025 release wave 1 feature "Running objects in actions defaults to UI descriptors on target object" — and the now-duplicate
ToolTipis removed from the page actions.Reports moved: Customer - Order Detail, Customer - Order Summary, Customer/Item Sales, Salesperson - Commission, Salesperson - Sales Statistics.
This completes the Sales area — the pre-migration ADO pass left these behind, including reports skipped by a since-fixed tooling bug (reports with obsolete dataset columns).
classifynow reports Sales = 0 remaining.Scope
src/Layers/W1/BaseApp): 14 files — 5 report-level ToolTip adds + 23 duplicate action ToolTip removals (descriptive + stub variants) across 9 pages/role centers. Some referencing actions live in other namespaces (CRM / Finance / shared RoleCenters); those are cleaned too, so the move is complete regardless of where the report is invoked.Metadata-only, tooltip-only diff; BOM/EOL preserved.
Fixes AB#636017