Skip to content

[master] Description Field value gets automatically reverted the original value after changing it.#9585

Open
neeleshsinghal wants to merge 2 commits into
mainfrom
bugs/Bug-638838-Description-Field-value-gets-automatically-reverted
Open

[master] Description Field value gets automatically reverted the original value after changing it.#9585
neeleshsinghal wants to merge 2 commits into
mainfrom
bugs/Bug-638838-Description-Field-value-gets-automatically-reverted

Conversation

@neeleshsinghal

@neeleshsinghal neeleshsinghal commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Issue: After validating Quantity on a sales line, editing the Description reverts it to the original item value when "Calc. Inv. Discount" is enabled (Bug 638838).

Cause: In CalculateSalesSubPageTotals, NeedRefreshSalesLine := false; was reset after the if TotalsUpToDate then exit; early-exit, so the flag set true by the Quantity validation stayed stuck, and RefreshSalesLine's Rec.Find() reloaded the line from the DB, discarding the uncommitted Description edit.

Solution: Moved NeedRefreshSalesLine := false; before the early-exit, so when totals are already up-to-date (no recalculation), the flag is cleared and RefreshSalesLine no longer overwrites the user's edit.

Workitem: Bug 638838: [master] [all-e] RFH: [SaaS] Description Field value gets automatically reverted the original value after changing it.

Fixes AB#638838

@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 17, 2026
@github-actions github-actions Bot added the SCM GitHub request for SCM area label Jul 17, 2026
@neeleshsinghal
neeleshsinghal marked this pull request as ready for review July 18, 2026 11:07
@neeleshsinghal
neeleshsinghal requested a review from a team July 18, 2026 11:07
Comment thread src/Layers/W1/Tests/ERM/DocumentTotalsPages.Codeunit.al
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

All 16 sub-skills ran to completion (as completed or no-knowledge); one style finding surfaced. Self-review pass considered one cross-cutting candidate (event var-parameter behavior change) but did not emit it because it depends on external subscriber code not visible in this repository, per the DO precision bar.

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain Findings Knowledge-backed Agent Inline Fallback
Style 1 1 0 1 0

Totals: 1 knowledge-backed · 0 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant