[master] Description Field value gets automatically reverted the original value after changing it.#9585
Open
neeleshsinghal wants to merge 2 commits into
Conversation
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed
Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf Findings by domainFindings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).
Totals: 1 knowledge-backed · 0 agent findings. Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives. |
neeleshsinghal
enabled auto-merge
July 18, 2026 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: After validating Quantity on a sales line, editing the Description reverts it to the original item value when "Calc. Inv. Discount" is enabled (Bug 638838).
Cause: In CalculateSalesSubPageTotals, NeedRefreshSalesLine := false; was reset after the if TotalsUpToDate then exit; early-exit, so the flag set true by the Quantity validation stayed stuck, and RefreshSalesLine's Rec.Find() reloaded the line from the DB, discarding the uncommitted Description edit.
Solution: Moved NeedRefreshSalesLine := false; before the early-exit, so when totals are already up-to-date (no recalculation), the flag is cleared and RefreshSalesLine no longer overwrites the user's edit.
Workitem: Bug 638838: [master] [all-e] RFH: [SaaS] Description Field value gets automatically reverted the original value after changing it.
Fixes AB#638838