Skip to content

build(skills): improve release skill conventions#26746

Open
tylerbutler wants to merge 10 commits intomicrosoft:mainfrom
tylerbutler:improve-release-skill-conventions
Open

build(skills): improve release skill conventions#26746
tylerbutler wants to merge 10 commits intomicrosoft:mainfrom
tylerbutler:improve-release-skill-conventions

Conversation

@tylerbutler
Copy link
Copy Markdown
Member

@tylerbutler tylerbutler commented Mar 16, 2026

Summary

Improves the fluid-release skill based on lessons from the 2.91.0 release:

  • Require all release PRs to be opened as drafts and assigned to the release runner via --draft --assignee @me
  • Add a merge freeze announcement step after the release notes PR is created, prompting the user to notify the team in the "Fluid Framework All" Teams channel
  • Elevate the ADO blocker check from a passive reminder to a mandatory confirmation gate that blocks progress until the user responds
  • Add a pre-merge blocker re-check (GitHub + ADO) between Step 4 and Step 5 to catch late-breaking release blockers
  • Document the revert-and-regenerate workflow when a release-blocking PR with a changeset merges after the release notes PR
  • Never auto-merge the version bump PR — always merge manually to avoid race conditions with late-landing changesets
  • Fix Teams channel name to "Fluid Framework All"

…d blocker checks

- Open all release PRs as drafts assigned to the release runner
- Add merge freeze announcement step after release notes PR is opened
- Make ADO blocker check a mandatory confirmation step (not just a reminder)
- Add pre-merge blocker re-check to catch late-breaking issues
Copilot AI review requested due to automatic review settings March 16, 2026 21:17
@tylerbutler tylerbutler changed the title build(skills): improve release skill with draft PRs, merge freeze, and blocker checks build(skills): improve release skill conventions Mar 16, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the fluid-release skill guidance to make release PR handling and blocker checks more explicit and harder to miss during minor/patch release execution.

Changes:

  • Make ADO release-blocker verification an explicit confirmation step (not just a reminder).
  • Add a merge-freeze announcement reminder after opening the release notes PR.
  • Add a pre-merge blocker re-check step before merging release-prep PRs.
  • Document that release PRs should be opened as drafts and assigned to the release runner.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
.claude/skills/fluid-release/references/release-execution.md Tightens blocker-handling guidance by requiring explicit ADO confirmation before proceeding.
.claude/skills/fluid-release/references/minor-release-prep.md Adds merge-freeze reminder and a pre-merge blocker re-check section; updates release notes PR instructions for draft/assignee.
.claude/skills/fluid-release/SKILL.md Makes ADO blocker check mandatory and documents draft+assignee conventions for release PRs.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread .claude/skills/fluid-release/SKILL.md Outdated
Comment thread .claude/skills/fluid-release/references/minor-release-prep.md Outdated
Comment thread .claude/skills/fluid-release/references/minor-release-prep.md Outdated
Comment thread .claude/skills/fluid-release/references/release-execution.md
Comment thread .claude/skills/fluid-release/SKILL.md Outdated
Comment thread .claude/skills/fluid-release/references/minor-release-prep.md Outdated
tylerbutler and others added 5 commits March 16, 2026 14:21
- Fix Teams channel name: "Fluid Framework All" not "General"
- Remove redundant gh api user instruction (--assignee @me suffices)
- Clarify "assigned to you" → explicit --assignee @me reference
- Clarify autonomous/CI ADO check is a hard stop, not just logging
When a release-blocking PR merges after the release notes PR (adding a
new changeset), the release notes must be reverted and regenerated to
include the new content.
Auto-merge creates a race condition where a late release-blocking PR
with a changeset can land after release notes but before the bump,
requiring a more complex recovery on the release branch.
Rename "Pre-merge Blocker Check" to "Pre-merge Gate: Blocker Re-check"
and add explicit placement guidance, addressing Copilot review feedback
that the heading didn't match the document's step numbering pattern.
The section is intentionally not a numbered step since it's a gate
between Steps 1-4 and Step 5, not a sequential action.
@tylerbutler tylerbutler requested review from a team and noencke March 18, 2026 21:47
@tylerbutler tylerbutler self-assigned this Mar 19, 2026
Comment thread .claude/skills/fluid-release/SKILL.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  272202 links
    1863 destination URLs
    2108 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants