Fix end to end perf tests, adding missing build dependency.#27384
Open
CraigMacomber wants to merge 1 commit into
Open
Fix end to end perf tests, adding missing build dependency.#27384CraigMacomber wants to merge 1 commit into
CraigMacomber wants to merge 1 commit into
Conversation
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (5 lines, 1 files), I've queued these reviewers:
How this works
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes failures in the performance benchmarks pipeline by ensuring an additional workspace package produces required CommonJS build artifacts before the end-to-end test ESM build runs.
Changes:
- Extend
build:test:esmbuild prerequisites to include@fluid-private/test-version-utils#tscsodist/compatOptions.jsexists for mocha configuration resolution. - Update the
fluidBuildtask comment to document why bothtest-driver-definitionsandtest-version-utilsneed CJS builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes failing Perforance benchmarks pipeline (example error from a recent commit): https://dev.azure.com/fluidframework/internal/_build/results?buildId=401966&view=logs&j=e3692cd0-efaa-5893-0f26-144e0d777cf6&t=f2c96dea-05f0-5622-1b27-0012e536e036
This solution was worked out by copilot, and might not be ideal: I do not fully understand the situation.
Reviewer Guidance
The review process is outlined on this wiki page.