Skip to content

Fix end to end perf tests, adding missing build dependency.#27384

Open
CraigMacomber wants to merge 1 commit into
microsoft:mainfrom
CraigMacomber:fixPerfE2e
Open

Fix end to end perf tests, adding missing build dependency.#27384
CraigMacomber wants to merge 1 commit into
microsoft:mainfrom
CraigMacomber:fixPerfE2e

Conversation

@CraigMacomber
Copy link
Copy Markdown
Contributor

Description

This fixes failing Perforance benchmarks pipeline (example error from a recent commit): https://dev.azure.com/fluidframework/internal/_build/results?buildId=401966&view=logs&j=e3692cd0-efaa-5893-0f26-144e0d777cf6&t=f2c96dea-05f0-5622-1b27-0012e536e036

This solution was worked out by copilot, and might not be ideal: I do not fully understand the situation.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings May 22, 2026 00:29
@github-actions
Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (5 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes failures in the performance benchmarks pipeline by ensuring an additional workspace package produces required CommonJS build artifacts before the end-to-end test ESM build runs.

Changes:

  • Extend build:test:esm build prerequisites to include @fluid-private/test-version-utils#tsc so dist/compatOptions.js exists for mocha configuration resolution.
  • Update the fluidBuild task comment to document why both test-driver-definitions and test-version-utils need CJS builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants