Skip to content

chore: Remove unused parameters and definitions from main.parameters.json and main.waf.parameters.json#371

Merged
Roopan-Microsoft merged 14 commits intodevfrom
psl-bicep-param
Apr 9, 2026
Merged

chore: Remove unused parameters and definitions from main.parameters.json and main.waf.parameters.json#371
Roopan-Microsoft merged 14 commits intodevfrom
psl-bicep-param

Conversation

@Harmanpreet-Microsoft
Copy link
Copy Markdown
Contributor

Purpose

This pull request simplifies the Azure infrastructure parameter files by removing several parameters related to backend and frontend resource definitions, existence checks, and AI model deployments. The changes streamline the configuration, likely to reduce complexity and potential confusion in deployment.

Removed parameters from infrastructure configuration:

Backend and Frontend Resource Parameters:

  • Removed backendExists, frontendExists, backendDefinition, and frontendDefinition parameters from both main.parameters.json and main.waf.parameters.json. These parameters previously controlled the existence and configuration of backend and frontend resources. [1] [2] [3]

Identity and AI Model Deployment Parameters:

  • Removed principalId and aiModelDeployments parameters from both parameter files. These were used for Azure identity and specifying AI model deployment configurations. [1] [2]
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

…ting log analytics workspace resource ID across workflows
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines and renames Azure infra parameters/env-var wiring across the Bicep templates, ARM JSON output, deployment parameter files, and GitHub Actions workflows so deployments use the updated parameter set and naming.

Changes:

  • Renames several infra parameters (model deployment type/capacity, image tag, ACR endpoint, “existing Foundry project” RID) and removes previously included “backend/frontend exists/definition” and AI deployment array parameters from parameter files.
  • Updates main.bicep / main_custom.bicep and the compiled main.json to use the renamed parameters.
  • Updates GitHub Actions workflow inputs/validation to match the new env var names (Log Analytics RID + Foundry Project RID) and adds optional RG tagging.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
infra/main.parameters.json Renames/removes parameters; updates env-var substitution keys.
infra/main.waf.parameters.json Aligns WAF parameters with renamed keys and updated VM/admin env vars.
infra/main.bicep Renames parameters and updates references throughout the deployment.
infra/main_custom.bicep Mirrors main.bicep renames for the custom template.
infra/main.json Recompiled ARM template reflecting renamed parameters.
docs/CustomizingAzdParameters.md Updates some parameter/env-var documentation to new names.
.github/workflows/job-deploy.yml Renames inputs for existing resource RIDs; adds RG tag support; updates validation.
.github/workflows/job-deploy-linux.yml Renames inputs and EXP wiring for Linux azd deployment path.
.github/workflows/job-deploy-windows.yml Renames inputs and EXP wiring for Windows azd deployment path.
.github/workflows/deploy.yml Updates direct az deployment group create parameter name to imageTag.
.github/workflows/deploy-v2.yml Renames workflow inputs/outputs and validation for existing resource RIDs.
.github/workflows/deploy-orchestrator.yml Renames orchestrator inputs to the new RID variable names.
.github/workflows/azure-dev.yml Updates dev workflow to use the renamed GPT capacity env var.
Comments suppressed due to low confidence (1)

docs/CustomizingAzdParameters.md:22

  • The parameter names were updated in this PR, but this table still lists older env vars (e.g., AZURE_ENV_IMAGETAG, AZURE_ENV_JUMPBOX_ADMIN_USERNAME/PASSWORD, and AZURE_ENV_COSMOS_SECONDARY_LOCATION) that no longer match infra/main*.parameters.json (AZURE_ENV_IMAGE_TAG, AZURE_ENV_VM_ADMIN_USERNAME/PASSWORD, AZURE_ENV_SECONDARY_LOCATION). Please update the table (and any linked docs like re-use-log-analytics / re-use-foundry-project) so users don’t set env vars that are now ignored.
| `AZURE_ENV_EXISTING_LOG_ANALYTICS_WORKSPACE_RID`| string  | Guide to get your [Existing Workspace ID](/docs/re-use-log-analytics.md)     | Set this if you want to reuse an existing Log Analytics Workspace instead of creating a new one.     |
| `AZURE_ENV_IMAGETAG`                   | string  | `latest`         | Set the Image tag Like (allowed values: latest, dev, hotfix)    |
| `AZURE_ENV_VM_SIZE`                   | string  | `Standard_D2s_v5`         | Specifies the size of the Jumpbox Virtual Machine (e.g., `Standard_D2s_v5`, `Standard_D2s_v4`). Set a custom value if `enablePrivateNetworking` is `true`.    |
| `AZURE_ENV_JUMPBOX_ADMIN_USERNAME`     | string  | `JumpboxAdminUser`          | Specifies the administrator username for the Jumpbox Virtual Machine.      |
| `AZURE_ENV_JUMPBOX_ADMIN_PASSWORD`     | string  | `JumpboxAdminP@ssw0rd1234!` | Specifies the administrator password for the Jumpbox Virtual Machine.      |

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/job-deploy.yml
Comment thread .github/workflows/job-deploy-linux.yml Outdated
Comment thread .github/workflows/job-deploy-linux.yml
Comment thread .github/workflows/job-deploy-linux.yml
Comment thread .github/workflows/job-deploy-windows.yml
Comment thread .github/workflows/job-deploy-windows.yml
Comment thread .github/workflows/job-deploy-windows.yml
Comment thread infra/main.parameters.json
Comment thread infra/main.waf.parameters.json
Comment thread docs/CustomizingAzdParameters.md Outdated
… and AI project resource ID in deployment workflows
@Roopan-Microsoft Roopan-Microsoft merged commit 53d8363 into dev Apr 9, 2026
6 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants