Skip to content

fix: gp bug and Managed identity changes#375

Merged
Roopan-Microsoft merged 7 commits intodevfrom
psl-fix-gp-bug
Apr 9, 2026
Merged

fix: gp bug and Managed identity changes#375
Roopan-Microsoft merged 7 commits intodevfrom
psl-fix-gp-bug

Conversation

@Shreyas-Microsoft
Copy link
Copy Markdown
Collaborator

Purpose

This pull request introduces several improvements and fixes across both the backend and frontend. The main changes include enhanced Azure credential handling for different environments, improved logging configuration for debugging, a fix to the script conversion loop logic, and frontend updates for better progress tracking and error handling.

Backend Improvements

  • Azure credential handling is now environment-aware: in development, it uses ClientSecretCredential or AioDefaultAzureCredential, while in production it defaults to AioManagedIdentityCredential, ensuring the correct authentication method is used based on APP_ENV. [1] [2]
  • Logging levels for both basic application logs and Azure package logs are set to DEBUG by default in .env.sample to facilitate easier debugging during development.
  • The script conversion loop in convert_script.py now uses a boolean flag (is_complete) for clearer and more robust completion detection. [1] [2]

Frontend Enhancements

  • Added progressPercentage state and improved the loading timeout logic to show an error only if progress is less than 5% after 30 seconds, providing a better user experience during long operations. [1] [2]
  • Updated .dockerignore to exclude node_modules, dist, and .git from frontend Docker builds, reducing image size and build time.

Other minor changes include importing additional React hooks and minor refactoring of file loading logic in the modernization page. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to improve “golden path” reliability and environment-aware Azure authentication, while enhancing the modernization UI’s progress/error handling and tightening Docker build context for the frontend.

Changes:

  • Backend: make Azure credential selection depend on APP_ENV (dev vs non-dev) and adjust script-conversion loop completion detection.
  • Frontend: adjust modernization page completion/navigation logic and add a progress-based loading timeout behavior.
  • Build: reduce frontend Docker build context via .dockerignore.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/frontend/src/pages/modernizationPage.tsx Updates modernization progress/navigation/error handling and file-loading logic.
src/frontend/.dockerignore Excludes bulky/unneeded dirs from frontend Docker build context.
src/backend/sql_agents/convert_script.py Refactors conversion loop termination logic using a boolean completion flag.
src/backend/common/config/config.py Makes Azure credential selection environment-aware (dev vs prod/managed identity).
src/backend/.env.sample Sets sample logging levels to DEBUG for easier development debugging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Roopan-Microsoft Roopan-Microsoft merged commit 7aa2173 into dev Apr 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants