Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ts/packages/agentServer/client/src/agentServerClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ import {
RunMacroRequest,
RunMacroResponse,
SearchMacrosRequest,
SubmitMacroCandidateRequest,
TraceSummary,
ValidateMacroRequest,
getDispatcherChannelName,
Expand Down Expand Up @@ -160,6 +161,9 @@ export type AgentServerConnection = {
disableMacro(request: DisableMacroRequest): Promise<MacroVersionRef>;
deleteMacro(request: DeleteMacroRequest): Promise<void>;
runMacro(request: RunMacroRequest): Promise<RunMacroResponse>;
submitMacroCandidate(
request: SubmitMacroCandidateRequest,
): Promise<MacroVersionRef>;
cancelMacroRun(runId: string): Promise<void>;
getMacroRun(runId: string): Promise<MacroRunRecord>;

Expand Down Expand Up @@ -396,6 +400,12 @@ export function createAgentServerConnection(
return rpc.invoke("runMacro", request);
},

async submitMacroCandidate(
request: SubmitMacroCandidateRequest,
): Promise<MacroVersionRef> {
return rpc.invoke("submitMacroCandidate", request);
},

async cancelMacroRun(runId: string): Promise<void> {
return rpc.invoke("cancelMacroRun", runId);
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ export function makeStubConnection(
async runMacro() {
throw new Error("Not implemented by conversation test stub");
},
async submitMacroCandidate() {
throw new Error("Not implemented by conversation test stub");
},
async cancelMacroRun() {},
async getMacroRun() {
throw new Error("Not implemented by conversation test stub");
Expand Down
1 change: 1 addition & 0 deletions ts/packages/agentServer/protocol/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export {
RunMacroRequest,
RunMacroResponse,
SearchMacrosRequest,
SubmitMacroCandidateRequest,
TraceSummary,
ValidateMacroRequest,
getDispatcherChannelName,
Expand Down
5 changes: 5 additions & 0 deletions ts/packages/agentServer/protocol/src/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import type {
RunMacroRequest,
RunMacroResponse,
SearchMacrosRequest,
SubmitMacroCandidateRequest,
TraceSummary,
ValidateMacroRequest,
} from "@typeagent/copilot-macros";
Expand Down Expand Up @@ -55,6 +56,7 @@ export type {
RunMacroRequest,
RunMacroResponse,
SearchMacrosRequest,
SubmitMacroCandidateRequest,
TraceSummary,
ValidateMacroRequest,
} from "@typeagent/copilot-macros";
Expand Down Expand Up @@ -213,6 +215,9 @@ export type AgentServerInvokeFunctions = {
disableMacro: (request: DisableMacroRequest) => Promise<MacroVersionRef>;
deleteMacro: (request: DeleteMacroRequest) => Promise<void>;
runMacro: (request: RunMacroRequest) => Promise<RunMacroResponse>;
submitMacroCandidate: (
request: SubmitMacroCandidateRequest,
) => Promise<MacroVersionRef>;
cancelMacroRun: (runId: string) => Promise<void>;
getMacroRun: (runId: string) => Promise<MacroRunRecord>;

Expand Down
2 changes: 2 additions & 0 deletions ts/packages/agentServer/server/src/connectionHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,8 @@ export function createAgentServerConnectionHandler(
disableMacro: async (request) => macroManager.disableMacro(request),
deleteMacro: async (request) => macroManager.deleteMacro(request),
runMacro: async (request) => macroManager.runMacro(request),
submitMacroCandidate: async (request) =>
macroManager.submitMacroCandidate(request),
cancelMacroRun: async (runId) => macroManager.cancelMacroRun(runId),
getMacroRun: async (runId) => macroManager.getMacroRun(runId),

Expand Down
36 changes: 35 additions & 1 deletion ts/packages/agentServer/server/test/macroRecordingRpc.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,41 @@ describe("macro recording RPC", () => {
status: "completed",
macroId: approved.macroId,
});

const approvedMacro = await connection.inspectMacro(approved);
await expect(
connection.runMacro({
runId: "agent-run-1",
macroId: approved.macroId,
version: approved.version,
preference: "agent",
}),
).resolves.toMatchObject({
status: "agentRequired",
launch: {
agent: "typeagent-macro-runner",
candidate: { handoffRunId: "agent-run-1" },
},
});
const candidate = await connection.submitMacroCandidate({
sourceMacroId: approved.macroId,
sourceVersion: approved.version,
handoffRunId: "agent-run-1",
reason: "Adapted during agent-guided execution.",
inputs: approvedMacro.inputs,
steps: approvedMacro.steps,
executionEvidence: {
outcome: "completed",
toolCalls: 1,
retries: 0,
durationMs: 100,
tokensUsed: 100,
steps: [{ stepId: "step-1", status: "completed" }],
},
});
expect(candidate).toMatchObject({ version: 3, state: "draft" });
await expect(connection.inspectMacro(approved)).resolves.toMatchObject({
state: "approved",
});
await connection.close();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,7 @@ function makeConnectionAdapter(): AgentServerConnection {
disableMacro: () => notSupported("disableMacro"),
deleteMacro: () => notSupported("deleteMacro"),
runMacro: () => notSupported("runMacro"),
submitMacroCandidate: () => notSupported("submitMacroCandidate"),
cancelMacroRun: () => notSupported("cancelMacroRun"),
getMacroRun: () => notSupported("getMacroRun"),

Expand Down
54 changes: 54 additions & 0 deletions ts/packages/copilot-macros/src/contracts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,15 @@ export interface CopilotToolMacro {
sourceTraceId: string;
createdAt: string;
warnings: string[];
candidateProvenance?: MacroCandidateProvenance;
}

export interface MacroCandidateProvenance {
sourceMacroId: string;
sourceVersion: number;
handoffRunId: string;
reason: string;
submittedAt: string;
}

export interface MacroSummary {
Expand Down Expand Up @@ -199,6 +208,50 @@ export interface RunMacroRequest extends InspectMacroRequest {
dryRun?: boolean;
}

export interface AgentRunnerLaunchPayload {
agent: "typeagent-macro-runner";
macro: CopilotToolMacro;
inputs: Record<string, unknown>;
reason: {
code: "agentRequested" | "agentRequired";
message: string;
stepIds: string[];
};
budgets: {
maxToolCalls: number;
maxRetries: number;
timeoutMs: number;
maxTokens: number;
};
candidate: {
sourceMacroId: string;
sourceVersion: number;
handoffRunId: string;
};
}

export interface SubmitMacroCandidateRequest {
sourceMacroId: string;
sourceVersion: number;
handoffRunId: string;
reason: string;
name?: string;
description?: string;
inputs: MacroInput[];
steps: MacroStep[];
executionEvidence: {
outcome: "completed";
toolCalls: number;
retries: number;
durationMs: number;
tokensUsed: number;
steps: Array<{
stepId: string;
status: "completed" | "failed" | "denied" | "cancelled";
}>;
};
}

export interface MacroRunStep {
stepId: string;
toolName: string;
Expand Down Expand Up @@ -239,6 +292,7 @@ export type RunMacroResponse =
macroId: string;
version: number;
reason: string;
launch: AgentRunnerLaunchPayload;
};

export interface ReplayToolDescriptor {
Expand Down
Loading
Loading