Update Microsoft.WSLg to 1.0.79#40899
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned Microsoft.WSLg NuGet to 1.0.79-Beta2 and adjusts build/packaging plumbing so WSLg assets are located correctly and WSL’s OSS NOTICE generation/installation can incorporate WSLg’s NOTICE (now including Mesa attribution).
Changes:
- Bump
Microsoft.WSLgfrom1.0.78to1.0.79-Beta2inpackages.config. - Update CMake + WiX paths to WSLg assets to use the package-root layout (via
WSLG_SOURCE_DIRpointing at the NuGet root). - Update the NOTICE generation pipeline to restore the WSLg NuGet and append its
NOTICE.txt, and install the repo-rootNOTICE.txtinto the MSI (with MSI rebuild dependency tracking).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages.config |
Pins Microsoft.WSLg to 1.0.79-Beta2. |
CMakeLists.txt |
Points WSLG_SOURCE_DIR at the WSLg NuGet root and updates symlink/link paths for WSLg binaries/PDBs accordingly. |
msipackage/package.wix.in |
Installs NOTICE.txt into INSTALLDIR and updates WSLg asset paths (system.vhd, .rdp) to match the new WSLG_SOURCE_DIR layout. |
msipackage/CMakeLists.txt |
Ensures MSI packaging rebuilds when the repo-root NOTICE.txt changes by adding it as a dependency. |
.pipelines/wsl-build-notice.yml |
Restores the WSLg NuGet during NOTICE generation and appends its NOTICE.txt via the notice@0 task’s additionaldata. |
638344e to
aac2e7e
Compare
OneBlue
left a comment
There was a problem hiding this comment.
Hmm the -Beta2 part isn't expected here. Let me double check
|
The previous change broke UserConfigs, any chance this one could revert that bit of it: |
Do you have more context / details on this? |
The remap was needed for an earlier design where the MSI was going to ship WSLg's NOTICE.txt directly, but we pivoted to having the notice pipeline merge it into the repo's root NOTICE. In the final design nothing actually needs WSLG_SOURCE_DIR pointed at the package root every reference is manually re-adding /build/native/bin/ . I'll put up a follow-up PR to revert the remap and restore UserConfig.cmake.sample . |
Summary of the Pull Request
Update Microsoft.WSLg from 1.0.78 → 1.0.79 in packages.config.
This is the first WSLg release that includes the Mesa NOTICE entry, which is required for OSS compliance in the WSL MSI. After this bump lands and the notice pipeline re-runs, the auto-generated NOTICE will finally include Mesa.
PR Checklist
Detailed Description of the Pull Request / Additional comments
1.0.79 is the first WSLg release that ships the Mesa NOTICE entry, which is required for the OSS NOTICE.txt we install via the MSI (#40893). Without this update, the auto-generated NOTICE updates (e.g. #40898) cannot include Mesa.
Note: the package is available on the shine-oss WslDependencies feed this repo restores from.
Validation Steps Performed