-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Python: Fix OpenAIChatCompletionClient passing raw JSON-Schema dict response_format through unwrapped #7199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this needs a integration test, because if I recall correctly there are differences in the format for the structured output between Chat Completions and Responses API's.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added in 47e3a08 — a You're right that the wire formats differ — Chat Completions nests under
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we have a marker for integration tests, because I want this to hit the actual service, see tests in this file that have: @pytest.mark.flaky
@pytest.mark.integration
@skip_if_openai_integration_tests_disabled
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They do use those markers — both |
Uh oh!
There was an error while loading. Please reload this page.