sessions: flatten SessionState; move model/agent to Message, drafts#264
Merged
Conversation
Make SessionSummary a root-only catalog type and relocate model/agent selection onto individual messages, so per-message/per-draft selections are expressible and the "one timestamp, two writers" summary problem goes away. - Flatten SessionState: inline the shared metadata (provider, title, status, activity, project, workingDirectory, annotations) via a new SessionMetadata base; drop the embedded `summary` sub-object. - SessionSummary is now root-channel-only (listSessions / sessionAdded / sessionSummaryChanged); createdAt/modifiedAt are ISO-8601 strings, not numbers, matching our other timestamps. - Remove session/chat-level model & agent: drop them from SessionState, SessionSummary, ChatState, ChatSummary and delete the now-defunct session/modelChanged & session/agentChanged actions (+ createSession / createChat model/agent params). - Add model?/agent? to Message so a turn records the selection it used (editable/resendable) and the host default applies when absent. - Add ChatState.draft + client-dispatchable chat/draftChanged so clients can debounce-sync in-progress input and rehydrate composer UI per chat. - Session reducer no longer stamps a timestamp; chat reducer unchanged. - Drop 0.4.0/0.3.0 from SUPPORTED_PROTOCOL_VERSIONS (breaking change). - Regenerate all 5 clients + schema + reference docs; update hand-written reducers/host code/tests for Rust, Kotlin, Swift, Go, TypeScript. - Update guides/spec docs and per-client CHANGELOGs. - Add migration plugin+skill (plugins/session-metadata-migration-plugin) to help consumers upgrade. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collapse a single-statement `with_status_flag` call onto one line so `cargo fmt --check` passes in CI. No behavior change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sandy081
previously approved these changes
Jun 25, 2026
This was referenced Jun 26, 2026
dmitrivMS
approved these changes
Jun 26, 2026
connor4312
changed the title
roblourens
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187.
Makes
SessionSummarya root-only catalog type and relocates model/agent selection onto individual messages, so per-message and per-draft selections are expressible and the "one timestamp, two writers" summary divergence (#186) goes away.What changed & why
SessionState— inline the shared metadata (provider,title,status,activity,project,workingDirectory,annotations) via a newSessionMetadatabase interface; drop the embeddedsummarysub-object. One overlapping set of update actions instead of two.SessionSummaryis root-channel-only now (listSessions/root/sessionAdded/root/sessionSummaryChanged). ItscreatedAt/modifiedAtare ISO-8601 strings (were numbers), matchingChatSummaryand theresource*mtime/ctime. The host ownsmodifiedAtat its discretion.SessionState,SessionSummary,ChatState,ChatSummary; deleted the now-defunctsession/modelChanged&session/agentChangedactions and themodel/agentparams oncreateSession/createChat.Message— addedmodel?/agent?so a turn records the selection it used (editable/resendable); absent ⇒ agent-host default. There is no session-level selection.ChatState.draft+ client-dispatchablechat/draftChanged. Clients MAY debounce-sync in-progress input (not eager) and SHOULD rehydrate composer UI from anydraft. State-only; not mirrored ontoChatSummary.chat/draftChanged(set/clear). 100% branch coverage retained.0.4.0/0.3.0fromSUPPORTED_PROTOCOL_VERSIONS;0.5.0no longer negotiates them.plugins/session-metadata-migration-plugin(skill) to help consumers upgrade.Verification
npm run generateclean (no drift),npm run testgreen — 264 tests, lint,verify:release-metadata,verify:changelog, 100% reducer coverage.go test ./...), Rust (cargo test+ clippy clean), Swift (107) all green. Kotlin verified in apodmaneclipse-temurin:17-jdkcontainer (./gradlew testBUILD SUCCESSFUL).Notes for reviewers
SUPPORTED_PROTOCOL_VERSIONStruncation to[0.5.0].AHPAppexample (Xcode-only) was updated best-effort and is not built in CI.