sessions: add session-level inputNeeded aggregate#265
Draft
connor4312 wants to merge 2 commits into
Draft
Conversation
Surface every outstanding input request across a session's chats on the session channel so a client (e.g. a mobile app or tool-providing client) can discover and answer them without subscribing to individual chats. What changed and why: - Add `SessionState.inputNeeded` — a host-managed aggregate of outstanding input across all chats, keyed by an opaque `id`. Each entry carries the owning `chat` URI plus the identifiers needed to respond, so clients answer by dispatching the ordinary `chat/*` action to that chat's channel (no chat subscription required). State-only: no new response actions. - Add the `SessionInputRequest` union with three variants: `SessionChatInputRequest` (mirrors a `ChatInputRequest`), `SessionToolConfirmationRequest` (a `ToolCallConfirmationState`), and `SessionToolClientExecutionRequest` (a running tool the session delegates to an active client). - Add `ToolCallConfirmationState` union (`ToolCallPendingConfirmationState | ToolCallPendingResultConfirmationState`); an inline anonymous union isn't generatable across clients. - Add `session/inputNeededSet` / `session/inputNeededRemoved` server actions (upsert/remove) plus the canonical reducer and 6 fixtures (100% branch coverage). - Wire the new types/unions/actions through all four code generators and hand-port the reducer logic into the Rust, Go, Kotlin, and Swift clients. - Document the aggregate in the session-channel spec and add Unreleased entries to the root and all five client CHANGELOGs. Note: `SessionToolClientExecutionRequest.toolCall` is typed `ToolCallState` (documented as `running`) rather than `ToolCallRunningState`, because a direct single-variant struct reference can't round-trip the `status` discriminant on the wire in the Rust/Go generators. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reflow the `use crate::state::{...}` block in reducers.rs to satisfy
`cargo fmt --all -- --check`.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
reviewed
Jun 25, 2026
| /** A tool call awaiting parameter- or result-confirmation. */ | ||
| ToolConfirmation = 'toolConfirmation', | ||
| /** A running tool the session wants an active client to execute. */ | ||
| ToolClientExecution = 'toolClientExecution', |
Member
There was a problem hiding this comment.
I don't think I'm following this part? Everything else makes sense
Member
Author
There was a problem hiding this comment.
An active client can be a participant of a session and provide its tools for all chats. But in order to know a chat needs is waiting for it to run a tool, it needs to be subscribed to that chat. This solves that case just like the confirmation/input request parts do
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surface every outstanding input request across a session's chats on the session channel, so a client (mobile app, tool-providing client, etc.) can discover and answer them without subscribing to each chat.
This is state-only by design: each aggregate entry carries the owning
chatURI plus all identifiers needed to respond, so a client answers by dispatching the ordinarychat/*action to that chat's channel — no chat subscription, no new response actions.What changed & why
SessionState.inputNeeded— host-managed aggregate of outstanding input across all chats, keyed by an opaqueid.SessionInputRequestunion (discriminated onkind) with three variants:SessionChatInputRequest— mirrors a chat'sChatInputRequest(elicitation).SessionToolConfirmationRequest— aToolCallConfirmationStateawaiting confirmation, plusturnId.SessionToolClientExecutionRequest— a running tool the session delegates to an activeclientId.ToolCallConfirmationStateunion (ToolCallPendingConfirmationState | ToolCallPendingResultConfirmationState) — an inline anonymous union isn't generatable across clients, so it's named.session/inputNeededSet/session/inputNeededRemovedserver actions (upsert / remove) + canonical reducer + 6 fixtures (keeps reducer branch coverage at 100%).Reviewer notes
SessionToolClientExecutionRequest.toolCallis typedToolCallState(documented asrunning) rather thanToolCallRunningState: a direct single-variant struct reference can't round-trip thestatusdiscriminant on the wire in the Rust/Go generators (the discriminant lives on the union wrapper). Happy to switch to a precise one-variant union if preferred.Testing