Fixed "raise" with string literals instead of an exception#736
Merged
swernli merged 2 commits intomicrosoft:mainfrom Mar 24, 2026
Merged
Fixed "raise" with string literals instead of an exception#736swernli merged 2 commits intomicrosoft:mainfrom
swernli merged 2 commits intomicrosoft:mainfrom
Conversation
swernli
approved these changes
Mar 23, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
swernli
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I cloned the repo and immediately run into these pylance errors:
Raise with a string literal does not raise an exception in Python 3 - instead it leads to
TypeError: exceptions must derive from BaseException. This means any time this code path would be hit, it will error with a confusingTypeErrorinstead of the intended error message.