fix(firefox): add overlay to fix GCC 15 compilation errors#16455
Merged
christopherco merged 1 commit intotomls/base/mainfrom Apr 4, 2026
Merged
fix(firefox): add overlay to fix GCC 15 compilation errors#16455christopherco merged 1 commit intotomls/base/mainfrom
christopherco merged 1 commit intotomls/base/mainfrom
Conversation
WithEnoughCoffee
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated component definition for Firefox to apply overlays that work around GCC 15 build failures in Firefox 148.0, and removes the now-nontrivial component entry from the generated components-full.toml list.
Changes:
- Add
base/comps/firefox/firefox.comp.tomlwith twospec-search-replaceoverlays to disablebuild_testsandenable_mozilla_crashreporter. - Remove the bare
[components.firefox]entry frombase/comps/components-full.tomlsince Firefox now has a dedicated comp file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| base/comps/firefox/firefox.comp.toml | Introduces overlays to toggle spec %global macros to avoid GCC 15 compilation failures. |
| base/comps/components-full.toml | Removes Firefox from the “no per-component modifications” list now that it has a dedicated definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Firefox 148.0 fails to build with GCC 15 due to two issues: 1. mfbt/tests/TestIntegerRange.cpp uses uint8_t/uint16_t/uint32_t/uint64_t without #include <cstdint>. GCC 15 no longer leaks these types through transitive includes. Fix: disable build_tests (test binaries are not shipped in the RPM). 2. toolkit/crashreporter/breakpad-client/linux/handler/minidump_descriptor.h references non-existent field 'address_within_principal_mapping_'. Affects x86_64 where crash reporter is enabled. Fix: disable enable_mozilla_crashreporter. The build failure was masked by './mach build -v 2>&1 | cat -' which swallows the exit code, causing %install to run and packager.py to report AccumulatedErrors for all missing files. Verified: local x86_64 build succeeds with both overlays applied.
WithEnoughCoffee
force-pushed
the
fix/firefox-gcc15
branch
from
4fb2f68 to
c3024af
Compare
christopherco
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox 148.0 fails to build with GCC 15 due to two issues:
mfbt/tests/TestIntegerRange.cpp uses uint8_t/uint16_t/uint32_t/uint64_t without #include . GCC 15 no longer leaks these types through transitive includes. Fix: disable build_tests (test binaries are not shipped in the RPM).
toolkit/crashreporter/breakpad-client/linux/handler/minidump_descriptor.h references non-existent field 'address_within_principal_mapping_'. Affects x86_64 where crash reporter is enabled. Fix: disable enable_mozilla_crashreporter.
The build failure was masked by './mach build -v 2>&1 | cat -' which swallows the exit code, causing %install to run and packager.py to report AccumulatedErrors for all missing files.
Test Methodology