In Agent mode: Auto scroll to prompts like 'Continue'.#26
Open
raghucssit wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the Agent-mode chat UX by ensuring the chat view scrolls to the bottom when interactive prompts (e.g., “Continue”, tool confirmations, command-line prompts) appear, so users notice they need to take action.
Changes:
- Force-scroll
ChatContentViewerto bottom for Agent-mode (agent rounds) updates, regardless of prior manual scroll state. - Expose
scrollToBottom()publicly and introduceforceScrollToBottom()with delayed follow-up scrolling to handle layout timing. - Trigger scrolling when tool confirmation dialogs are created/closed so newly revealed controls are visible.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/InvokeToolConfirmationDialog.java | Scrolls the chat viewer after Continue/Cancel actions so follow-up UI is visible. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ChatContentViewer.java | Adds forced scrolling behavior for agent rounds; makes scrolling APIs available to child widgets. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/BaseTurnWidget.java | Scrolls the chat viewer to reveal newly created tool confirmation dialogs (prefer showControl). |
affbd79 to
8466547
Compare
Author
|
@jdneo I have fixed the copilot review comments.. |
Member
|
@raghucssit Thank you. I left some comments. |
8466547 to
0d3e257
Compare
User must be made aware some action is needed from them to continue the work by agent. Usually this happens when "Too many requests" or "Command line run prompt" etc. see https://github.com/microsoft/copilot-eclipse-feedback/issues/184
0d3e257 to
01672b4
Compare
jdneo
reviewed
May 12, 2026
| // For agent-mode responses (agent rounds/tool calls) we always force the view | ||
| // to scroll to the bottom so prompts that require user action (e.g. Continue, | ||
| // permission dialogs) are visible even if the user previously scrolled away. | ||
| if (value.getAgentRounds() != null && !value.getAgentRounds().isEmpty()) { |
Member
There was a problem hiding this comment.
Is there any reason to force scroll to bottom always when new agent round comes? Even if the user scroll is up (when scroll bar is not at the bottom)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User must be made aware some action is needed from them to continue the work by agent. Usually this happens when "Too many requests" or "Command line run prompt" etc.
see #120