Merged
Conversation
- herestring openers must be at EOL, closers must be at BOL - ` is the escape character for strings in this language - single quoted strings do not get escapes at all
Member
Author
|
Member
Author
|
Edit currently styles This is too "loud" inside the editor IMO. 
but maybe a red underline is called-for? |
Member
Author
|
I have some "as yet not finished" work to make the legal escape characters parse as a slightly different token, because there are only like 9 of them and other highlighters show them differently too. |
lhecker
reviewed
Mar 31, 2026
lhecker
reviewed
Mar 31, 2026
| } else if /"/ { | ||
| loop { | ||
| yield string; | ||
| if /\\./ {} |
DHowett
changed the title
DHowett
commented
Mar 31, 2026
| await input; | ||
| } | ||
| } else if /@"/ { | ||
| } else if /@'\s*$/ { |
Member
Author
There was a problem hiding this comment.
this avoids marking invalid ones as invalid, but it does still reject them.
Member
Author
There was a problem hiding this comment.
(it falls through to the normal string case later, which gobbles until it gets a ')
lhecker
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.