Add Shell, Python and JavaScript highlighting#795
Merged
Conversation
DHowett
reviewed
Apr 7, 2026
| } else if /'/ { | ||
| until /$/ { | ||
| yield string; | ||
| if /\\./ {} |
Member
There was a problem hiding this comment.
No escapes in single quoted strings, right?
Member
Author
There was a problem hiding this comment.
Single and double quoted strings in JS are actually equivalent.
| } else if /(?:true|false|null|undefined|NaN|Infinity)\>/ { | ||
| yield constant.language; | ||
| } else if /(?i:-?(?:0x[\da-fA-F_]+|0b[01_]+|0o[0-7_]+|[\d_]+\.?[\d_]*|\.[\d_]+)(?:e[+-]?[\d_]+)?)n?/ { | ||
| if /\w+/ { |
Member
There was a problem hiding this comment.
Argues for lsh to support an unless keyword
| } else if /'/ { | ||
| until /$/ { | ||
| yield string; | ||
| if /\\./ {} |
Member
There was a problem hiding this comment.
Probably should audit all of these for whether they should support escapes in single quotes
Member
Author
There was a problem hiding this comment.
To my knowledge (and testing) they are all correct.
DHowett
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: barkure 43804451+barkure@users.noreply.github.com