[dev-v5][Popover] Fix positioning for RTL mode#5014
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses incorrect popover positioning in RTL layouts (reported in #5013) by introducing RTL-aware alignment logic in the Popover component’s TypeScript positioning code.
Changes:
- Added RTL detection (
isRtl) to influence horizontal alignment decisions. - Deferred initial position adjustment to the next animation frame after opening.
- Updated horizontal positioning logic to use “start/end” semantics intended to map to LTR/RTL appropriately.
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.9%
Microsoft.FluentUI.AspNetCore.Components.Charts - 100%
|
vnbaaij
changed the title
dvoituron
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5013
The popover was not taking the correct RTL calculations for positioning the popover into account. This PR fixes that.
Before
After