fix(react-motion): apply MotionComponent type to presence definition#35952
Merged
layershifter merged 2 commits intomicrosoft:masterfrom Apr 7, 2026
Merged
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
robertpenner
force-pushed
the
refactor/motion-component-types
branch
from
322ba3f to
83458ce
Compare
layershifter
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
InandOutproperties ofPresenceComponentwere typed asReact.FC<MotionComponentProps & MotionParams>.[MOTION_DEFINITION]: AtomMotionFn<MotionParams>Slide.In, for example, withcreateMotionComponentVariant.New Behavior
InandOutproperties ofPresenceComponentare now typed asMotionComponent<MotionParams>.React.FCexpression, and it contains the specialMOTION_DEFINITIONsymbol.createMotionComponentVariant(Slide.In, { duration: 2000 })now works without a type error.Future Work
Spinnermotion migration in feat(react-spinner): migrate Spinner animations to motion components #35882.