feat(web-components): generate SSR templates and stylesheets into src/#36259
Draft
radium-v wants to merge 5 commits into
Draft
feat(web-components): generate SSR templates and stylesheets into src/#36259radium-v wants to merge 5 commits into
radium-v wants to merge 5 commits into
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…/ and copy into dist during compile
radium-v
force-pushed
the
wc-include-templates-in-src
branch
from
a3f8c09 to
f57ecfd
Compare
davatron5000
approved these changes
May 28, 2026
| * - `stale` — TS and HTML both at HEAD, but regen disagrees with disk | ||
| * (committed state is out of sync — CI failure signal) | ||
| * - `handEdited` — HTML differs from HEAD with no TS change; regen would clobber | ||
| * - `conflicts` — both TS and HTML differ from HEAD, and regen disagrees with disk |
Contributor
There was a problem hiding this comment.
What's the resolution process for situations where edits would be clobbered? Do we have that documented somehwere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
SSR template HTML and stylesheet CSS were generated at build time and written only to
dist/. The output had no presence insrc/, was never committed, and contributors had no way to inspect the DSD output without running a build.New Behavior
SSR templates and stylesheets are now generated next to their
*.template.ts/*.styles.tssiblings insrc/and committed to the repo. This makes the DSD output visible during the WC v3 alpha.yarn compileno longer regenerates them; it copiessrc/**/*.template.htmlandsrc/**/*.styles.cssintodist/esm/.yarn generate:ssrruns the harness'sgenerateFTemplatesandgenerateStylesheetswithoutDir: 'src'and formats the result with Prettier.yarn check:ssrruns the generators against a staging directory and compares the result tosrc/and the working tree. It reportsunchanged,created,updated,stale,handEdited, andconflicts, and exits non-zero when stale, hand-edited, or conflicting files appear.yarn compileis extended to copysrc/**/*.template.htmlandsrc/**/*.styles.cssintodist/esm/aftertsc, preserving subdirectory structure. The oldbuild:ssr,build:ssr:styles, andbuild:ssr:templatesscripts were removed.