docs(web-components): match storybook argTypes to custom element manifest#36271
docs(web-components): match storybook argTypes to custom element manifest#36271davatron5000 wants to merge 15 commits into
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
| ariaLabelledby: { | ||
| control: 'text', | ||
| name: 'aria-labelledby', | ||
| table: { category: 'attributes' }, |
There was a problem hiding this comment.
Is there a separate category for aria attributes?
There was a problem hiding this comment.
I started down that path but abandoned in in the sorting exercises... but I'm willing to add that separation back in. It made the tables a little bit noisy but I do like the separation. LMK if it's a MUST HAVE for you.
|
@radium-v @marchbox Thanks for the feedback because it made me realize there's got to be a better way. I pushed up some changes to the extent that this could be considered an entirely different PR. Here's what changed from before:
This has cleaned up a lot of the gnarliness from the previous PR and exposed some documentation pieces my previous The wc-toolkit fork is 90% the same but with three critical differences that map to how our stories work:
The biggest change here is that we're leveraging the CEM for 90% of our storybook Possible future explorations are fixing ordering and using the CEM for default |
Previous Behavior
Nearly all stories had either an error or some sort of missing property
New Behavior
verify-storybookscript that verifies that Storybook matches the CEMverify-storybookwill also surface missing JSDocs for cssProps/cssVars/events in the component classautofocusfrom all component classes because this is a feature of HTML, not our components (Tests passed in all browsers locally)Related Issue(s)