fix: prevent Calendar day cells from expanding#36286
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Calendar day cells could expand when an app-level table-cell padding rule had higher specificity than the default day-cell padding. For example, a scoped
td { padding: 15px; }rule can turn the intended 28px cell into a 58px cell, which matches the DatePicker overflow reported in #36274.New Behavior
Calendar day cells keep their fixed sizing by using border-box sizing and a higher-specificity zero-padding rule for the day-cell slot. This keeps the day grid at its expected width even when a surrounding app has scoped table-cell padding.
Related Issue(s)
Tests
corepack yarn nx run react:test --testPathPatterns=CalendarDayGrid.test.tsx --runInBand --excludeTaskDependenciesnode node_modules\\eslint\\bin\\eslint.js packages\\react\\src\\components\\CalendarDayGrid\\CalendarDayGrid.styles.ts packages\\react\\src\\components\\CalendarDayGrid\\CalendarDayGrid.test.tsxnode node_modules\\prettier\\bin-prettier.js --check packages\\react\\src\\components\\CalendarDayGrid\\CalendarDayGrid.styles.ts packages\\react\\src\\components\\CalendarDayGrid\\CalendarDayGrid.test.tsx change\\@fluentui-react-5e1a9878-e11f-4ae1-9cbf-71a0a7d296b9.jsongit diff --checktd { padding: 15px; }.