Skip to content

[CHERRY-PICK] MdePkg/BaseLib: Add AsmReadFsBase and AsmWriteFsBase for X86-64#1804

Merged
makubacki merged 1 commit into
microsoft:release/202511from
Gowtham-Manikandan:release/202511
May 22, 2026
Merged

[CHERRY-PICK] MdePkg/BaseLib: Add AsmReadFsBase and AsmWriteFsBase for X86-64#1804
makubacki merged 1 commit into
microsoft:release/202511from
Gowtham-Manikandan:release/202511

Conversation

@Gowtham-Manikandan
Copy link
Copy Markdown

@Gowtham-Manikandan Gowtham-Manikandan commented May 21, 2026

Description

The commit that adds Asm(Read|Write)FsBase to BaseLib for x86-64.
(cherry picked from commit e2b0e207f7b1009a6729f7973ed17242cb6672a4)

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Call AsmWriteFsBase() and use AsmReadFsBase() to check if the value is written to FSBASE.

Integration Instructions

N/A

@mu-automation
Copy link
Copy Markdown
Contributor

mu-automation Bot commented May 21, 2026

✅ QEMU Validation Passed

Source Dependencies

Repository Commit
mu_basecore 95e7870
mu_tiano_platforms 274d484

Results

Platform Target Build Boot Overall Boot Time Build Logs Boot Logs
Q35 DEBUG ✅ success ✅ success 0m 17s Build Logs Boot Logs
SBSA DEBUG ✅ success ✅ success 0m 34s Build Logs Boot Logs

Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/26307549638

This comment was automatically generated by the Mu QEMU PR Validation workflow.

@Gowtham-Manikandan
Copy link
Copy Markdown
Author

@Gowtham-Manikandan please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 21, 2026

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/202511@1800e61). Learn more about missing BASE report.

Files with missing lines Patch % Lines
MdePkg/Library/BaseLib/X64/FsGsBase.c 0.00% 39 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202511    #1804   +/-   ##
=================================================
  Coverage                  ?    2.21%           
=================================================
  Files                     ?     1634           
  Lines                     ?   420108           
  Branches                  ?     4949           
=================================================
  Hits                      ?     9308           
  Misses                    ?   410725           
  Partials                  ?       75           
Flag Coverage Δ
FmpDevicePkg 9.53% <ø> (?)
MdeModulePkg 1.58% <ø> (?)
MdePkg 5.44% <0.00%> (?)
NetworkPkg 0.55% <ø> (?)
PolicyServicePkg 30.42% <ø> (?)
SecurityPkg 1.59% <ø> (?)
UefiCpuPkg 4.78% <ø> (?)
UnitTestFrameworkPkg 11.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@os-d os-d requested review from apop5 and makubacki May 21, 2026 15:41
Copy link
Copy Markdown
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edk2 commit message is empty for this one, so I'm fine to just do a squash on this and take the cherry-pick name and the commit hash in the PR description.

Usually, we would do git cherry-pick -x <hash>, then amend the commit to add [CHERRY-PICK] to the title so we retain the edk2 commit information but still know for ourselves it was a cherry-pick.

@makubacki
Copy link
Copy Markdown
Member

makubacki commented May 21, 2026

The edk2 commit message is empty for this one, so I'm fine to just do a squash on this and take the cherry-pick name and the commit hash in the PR description.

Usually, we would do git cherry-pick -x <hash>, then amend the commit to add [CHERRY-PICK] to the title so we retain the edk2 commit information but still know for ourselves it was a cherry-pick.

I don't think we'll preserve the author in the squash. If we can change it back to Ray, fine. Otherwise, it'd be more consistent to at the -x line to the empty commit message and preserve the author/committer appropriately.

@makubacki
Copy link
Copy Markdown
Member

makubacki commented May 21, 2026

Note: Current SBSA boot failure is due to a recent, unrelated change.

@Gowtham-Manikandan Gowtham-Manikandan force-pushed the release/202511 branch 2 times, most recently from 4540aad to 9e19e68 Compare May 22, 2026 04:48
…r X86-64

Signed-off-by: Ray Ni <ray.ni@intel.com>
(cherry picked from commit e2b0e207f7b1009a6729f7973ed17242cb6672a4)
@makubacki
Copy link
Copy Markdown
Member

@Gowtham-Manikandan, thanks for repushing so the author was correct. The Signed-off-by line and the cherry-pick -x line were still missing from the commit message, so I pushed that update to your PR branch. I've set automerge for the PR as well.

@makubacki makubacki enabled auto-merge (rebase) May 22, 2026 19:04
@makubacki makubacki merged commit cd8fb3a into microsoft:release/202511 May 22, 2026
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants