Skip to content

Permissive Learning Mode 3/6 Config Generation#586

Open
lilybarkley-msft wants to merge 1 commit into
user/lilybarkley/plm-pr2-fs-extractionfrom
user/lilybarkley/plm-pr3-config-gen
Open

Permissive Learning Mode 3/6 Config Generation#586
lilybarkley-msft wants to merge 1 commit into
user/lilybarkley/plm-pr2-fs-extractionfrom
user/lilybarkley/plm-pr3-config-gen

Conversation

@lilybarkley-msft

@lilybarkley-msft lilybarkley-msft commented Jun 27, 2026

Copy link
Copy Markdown

📖 Description

PR 3 of 6 — stacked on PR2. Adds config generation.

  • Adjusted_<name>.json writer next to the captured trace (or override path)
  • resolve_adjusted_config_path + save_adjusted_config
  • Detection-summary writers (no UI fields yet — added in PR5):
    • write_added_paths_summary
    • write_detection_summary — per-path / per-mask grouping
    • write_requested_capabilities_summary
  • Access-mask decoder + classifier (decode_access_mask / classify_mask)
  • merge_capabilities stub that errors on non-empty input — PR4 fills in the real body. The stub keeps wiring intact without silently dropping findings if a stray caller appears mid-stack.

stop is wired to produce a full Adjusted_<name>.json + detection summary for filesystem deltas.

🔗 References

  • Base: PR2 (user/lilybarkley/plm-pr2-fs-extraction)
  • Next: PR4 — capability extraction (replaces merge_capabilities stub + adds DACL ACE blob decoding)

🔍 Validation

  • cargo build -p plm --target x86_64-pc-windows-msvc — clean
  • cargo fmt --all -- --check — clean
  • cargo clippy -p plm --target x86_64-pc-windows-msvc --all-targets -- -D warnings — clean
  • cargo test -p plm --target x86_64-pc-windows-msvc37 passed (test count steady; PR3 changes are write-paths exercised end-to-end in PR4+).

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task

GitHub Actions runs the PR validation build automatically. The ADO pipeline
(MXC-PR-Build) is the official build pipeline that signs the binaries; it
runs on merge to main and nightly, and Microsoft reviewers can trigger it
on a PR with /azp run. See docs/pull-requests.md.

Microsoft Reviewers: Open in CodeFlow

Adds the Adjusted_*.json writer, the per-event detection summary, and a
merge_capabilities stub that errors when called with a non-empty set
(PR2's parser never produces one; PR4 fills in the body).

New config.rs functions:
- resolve_adjusted_config_path, save_adjusted_config (pretty JSON +
  parent-dir create)
- write_detection_summary (file paths + capabilities; UI section
  arrives in the UI-policy PR)
- write_requested_capabilities_summary (verbose dump)
- merge_capabilities stub

stop.rs now writes Adjusted_<input>.json with the merged filesystem
section.

37 tests pass; cargo fmt + clippy clean.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lilybarkley-msft lilybarkley-msft requested a review from a team as a code owner June 27, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant